Feature enhance source link #52
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cx-prathmesh-borle
requested review from
cx-apoorva-singh,
cx-rakesh-kadu and
cx-umesh-waghode
| var sastResultsUrl = apibaseurl + '/sast-results/' + appId + '/' + scanId; | ||
| var sastVulnerabilityLink = ''; | ||
| var resultHash = jsonLastScanReportResp.results[item].data.resultHash; | ||
| if (resultHash && resultHash != '') { |
There was a problem hiding this comment.
Replace if (resultHash && resultHash != '') with if (resultHash)
being falsy already covers empty strings.
| var kicsResultsUrl = apibaseurl + '/results/' + scanId + '/' + appId + '/kics'; | ||
| var kicsVulnerabilityLink = ''; | ||
| var kicsAlternateId = jsonLastScanReportResp.results[item].alternateId; | ||
| if (kicsAlternateId && kicsAlternateId != '') { |
There was a problem hiding this comment.
This can be simplified to just: if (kicsAlternateId)
| var imageName = jsonLastScanReportResp.results[item].data.imageName; | ||
| var imageTag = jsonLastScanReportResp.results[item].data.imageTag; | ||
|
|
||
| var encodedFilePath = encodeURIComponent(gs.base64Encode(imageFilePath)); |
There was a problem hiding this comment.
Optional : If any of the key fields are undefined or null (imageFilePath, imageName), the encoding functions may throw or produce "undefined" strings.
We may need to consider validations.
if (imageFilePath && imageName) {
// operations
}
| resultObj['source_link'] = node.getAttribute('sourcefile'); | ||
|
|
||
| var vulnerabilityLink = node.getAttribute('vulnerability_link'); | ||
| if (vulnerabilityLink && vulnerabilityLink != '') { |
There was a problem hiding this comment.
just use if (vulnerabilityLink) instead of if (vulnerabilityLink && vulnerabilityLink != '')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced source vulnerability links