feat(AstBuilder): add save method #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balzdur
commented
Aug 30, 2023
| @@ -1,12 +1,12 @@ | |||
| import { type NodeDto } from '@marble-api'; | |||
| import * as R from 'remeda'; | |||
|
|
|||
| export interface AstNode { | |||
| export type AstNode = { | |||
There was a problem hiding this comment.
This is required in order to be compatible with JSON type.
In short, interface do not have index type, and raise issue when passed as a JSON value.
(more info here)
| @@ -146,7 +144,7 @@ export default function RuleEdit() { | |||
| identifiers, | |||
| operators, | |||
| onSave: (astNodeToSave: AstNode) => { | |||
| fetcher.submit(JSON.stringify(astNodeToSave), { | |||
| fetcher.submit(astNodeToSave, { | |||
There was a problem hiding this comment.
This is where we need to have a type compatible with JSON type declaration.
Comment on lines
+184
to
+190
| <Button | ||
| type="submit" | ||
| className="w-fit" | ||
| onClick={() => { | ||
| astEditor.save(); | ||
| }} | ||
| > |
There was a problem hiding this comment.
We no longer use Form component
balzdur
force-pushed
the
thomas/refactor-builder
branch
from
ad9453e
to
dda24da
Compare
Vivien-marble
approved these changes
Aug 31, 2023
Pascal-Delange
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small changes to add the possibility to save changes.