Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Added *://*/ permission back due to issue #106 #107

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Added *://*/ permission back due to issue #106 #107

merged 1 commit into from
Oct 1, 2020

Conversation

jamieni
Copy link
Contributor

@jamieni jamieni commented Sep 30, 2020

Pull Request Template

Description

the scenario is when the iframe has a different base url than the original url.
i.e. original url: abc.com iframe url: abc-def.com

Type of change

Please delete options that are not relevant.
Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.
Manual testing

Checklist:

  • My code follows the style guidelines of this project. npm run lint passes with no errors.
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes. npm run test passes with no errors.

@maxigimenez
Copy link
Member

Thanks for contributing @jamieni

@maxigimenez maxigimenez linked an issue Oct 1, 2020 that may be closed by this pull request
@maxigimenez maxigimenez merged commit 3f6037e into checkly:master Oct 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can no longer access iframes
3 participants