Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: examples set runParallel:true [sc-00] #935

Merged
merged 1 commit into from
Feb 2, 2024
Merged

feat: examples set runParallel:true [sc-00] #935

merged 1 commit into from
Feb 2, 2024

Conversation

maxigimenez
Copy link
Member

I hereby confirm that I followed the code guidelines found at engineering guidelines

Affected Components

  • CLI
  • Create CLI
  • Test
  • Docs
  • Examples
  • Other

Notes for the Reviewer

Set examples to use runParallel: true by default

miliberlin
miliberlin reviewed Feb 2, 2024
View reviewed changes
Copy link
Member

@miliberlin miliberlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add multiple locations?

@maxigimenez
Copy link
Member Author

Should we also add multiple locations?

@miliberlin it has multiple locations already on the group level

@maxigimenez maxigimenez merged commit c48e07e into main Feb 2, 2024
3 checks passed
@maxigimenez maxigimenez deleted the maxigimenez/sc-00/examples-default-run-parallel-true branch February 2, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miliberlin miliberlin miliberlin left review comments

@shiini2 shiini2 shiini2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxigimenez @shiini2 @miliberlin