-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps-dev): Bump typescript from 4.9.4 to 5.3.3 #903
Conversation
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.9.4 to 5.3.3. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v4.9.4...v5.3.3) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
@@ -73,7 +73,7 @@ | |||
"@oclif/plugin-not-found": "2.3.23", | |||
"@oclif/plugin-plugins": "4.1.12", | |||
"@oclif/plugin-warn-if-update-available": "2.0.24", | |||
"@typescript-eslint/typescript-estree": "6.7.2", | |||
"@typescript-eslint/typescript-estree": "6.19.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to be a bit careful with this one. Each @typescript-eslint/typescript-estree"
only supports a specific range of TypeScript versions. This can end up being a breaking change for users. (#848)
I think we can make this change, but if the supported TS versions change it could be good to mention it in the release notes. The supported TypeScript versions are here: https://github.com/typescript-eslint/typescript-eslint/blob/920f909debc3eb394f5aef4e36568bdf6641e304/packages/typescript-estree/src/parseSettings/warnAboutTSVersion.ts#L9.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6.7.2 only supports up to 5.3 (so 5.3.3 of TS is not supported) 6.19.0 supports up to 5.4 and both of them support from 4.3.5 onwards
@tnolet @umutuzgur WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ferrandiaz this is above my paygrade. Please make the decision based on what's good for the users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both support 4.3.5 onwards, so we don't risk breaking anyones setup. I think we can just merge it 👍
Bumps typescript from 4.9.4 to 5.3.3.
Release notes
Sourced from typescript's releases.
... (truncated)
Commits
63717cf
Bump version to 5.3.3 and LKG4c2afa7
🤖 Pick PR #56627 (Transpile jsdoc parsing mode) into release-5.3 (#56629)ba3d2b0
🤖 Pick PR #56434 (Fix support for intersections in te...) into release-5.3 (#...f3808c4
🤖 Pick PR #56504 (Fixed an issue in boolean compariso...) into release-5.3 (#...b4fe221
Cherry-pick #56489 into release-5.3 (#56490)f750eb3
Pick #56485 into release-5.3 (#56486)27047e3
Update LKG.d09b1bf
Pick #56449 into release-5.3 (#56451)e2a5d45
Update LKG.756efd2
Fixes for release-5.3. (#56424)You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)