feat: add retryStrategy to the advanced examples #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clample
commented
Aug 31, 2023
| }); | ||
|
|
||
| module.exports = websiteGroup; | ||
| module.exports = { websiteGroup }; |
There was a problem hiding this comment.
There was a bug here since other *.check.js files were importing using:
const { websiteGroup } = require('./website-group.check');
This was causing the group to be empty when the advanced JS project is deployed.
clample
force-pushed
the
chrislample/add-retry-strategy-examples
branch
2 times, most recently
from
356ef6b
to
efdb888
Compare
clample
force-pushed
the
chrislample/add-retry-strategy-examples
branch
from
efdb888
to
17711e7
Compare
umutuzgur
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby confirm that I followed the code guidelines found at engineering guidelines
Affected Components
Notes for the Reviewer
This PR adds examples of the new
retryStrategyproperty to the advanced examples. Since this isn't supported on deprecated plans, deprecated users will get errors when running the advanced example.