Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate doubleCheck property #836

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

clample
Copy link
Collaborator

@clample clample commented Aug 31, 2023

I hereby confirm that I followed the code guidelines found at engineering guidelines

Affected Components

  • CLI
  • Create CLI
  • Test
  • Docs
  • Examples
  • Other

Notes for the Reviewer

The doubleCheck property for checks and groups is being replaced with retryStrategy, which allows for more flexibility in specifying how to retry failed check runs. This PR marks the doubleCheck property as deprecated so that users can begin migrating.

I also verified that doubleCheck isn't used in any of the examples.

Screenshot 2023-08-31 at 14 21 33

@clample clample requested a review from umutuzgur August 31, 2023 12:29
@clample clample enabled auto-merge (squash) August 31, 2023 12:30
@clample clample merged commit f655963 into main Aug 31, 2023
3 checks passed
@clample clample deleted the chrislample/deprecate-double-check-property branch August 31, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants