Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use ipv4 for local setup #827

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Conversation

clample
Copy link
Collaborator

@clample clample commented Aug 14, 2023

I hereby confirm that I followed the code guidelines found at engineering guidelines

Affected Components

  • CLI
  • Create CLI
  • Test
  • Docs
  • Examples
  • Other

Notes for the Reviewer

On Mac, I receive the following error when running the CLI with CHECKLY_ENV=local:

 Error: Encountered an error connecting to Checkly. Please check that the internet connection is working. connect ECONNREFUSED ::1:3000

The CLI tries to connect to the IPv6 loopback address. The local setup isn't bound to the IPv6 interface, though, so this fails. To fix the issue, we can make sure that the CLI always uses the IPv4 address.

@clample clample requested a review from nahuelon August 14, 2023 13:22
Copy link
Contributor

@nahuelon nahuelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@clample clample enabled auto-merge (squash) August 14, 2023 13:23
@clample clample merged commit f7dcaf3 into main Aug 14, 2023
3 checks passed
@clample clample deleted the chrislample/use-ipv4-local-setup branch August 14, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants