feat(heartbeat): print pingUrl in the console after deploy for heartbeat checks [sc-17085]
#820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tbeat checks [sc-17085]
|
This pull request has been linked to Shortcut Story #17085: Return ping URL on the CLI. |
maxigimenez
previously requested changes
Aug 9, 2023
ndom91
previously approved these changes
Aug 10, 2023
umutuzgur
reviewed
Aug 10, 2023
umutuzgur
reviewed
Aug 10, 2023
umutuzgur
reviewed
Aug 10, 2023
ndom91
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby confirm that I followed the code guidelines found at engineering guidelines
Affected Components
Notes for the Reviewer
When creating or updating heartbeat checks from
npx checkly deploy, we want to print in the console the ping URL of each heartbeat check.iTerm2:
Terminal with default theme:
Note: needs deploy response adjustment PR on the BE when testing.