Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add sslCheckDomain property [gh-0] #819

Merged
merged 4 commits into from
Aug 10, 2023
Merged

chore: add sslCheckDomain property [gh-0] #819

merged 4 commits into from
Aug 10, 2023

Conversation

nahuelon
Copy link
Contributor

@nahuelon nahuelon commented Aug 8, 2023

I hereby confirm that I followed the code guidelines found at engineering guidelines

Affected Components

  • CLI
  • Create CLI
  • Test
  • Docs
  • Examples
  • Other

Notes for the Reviewer

This PR adds sslCheckDomain into BrowserCheck construct.

Depends on https://github.com/checkly/checkly-backend/pull/4591

New Dependency Submission

@nahuelon nahuelon requested a review from clample August 9, 2023 15:09
clample
clample previously approved these changes Aug 9, 2023
View reviewed changes
@nahuelon nahuelon requested a review from clample August 9, 2023 15:19
@nahuelon nahuelon merged commit 6477e60 into main Aug 10, 2023
3 checks passed
@nahuelon nahuelon deleted the nahuelon/gh-0/add-sslcheckdomain-property branch August 10, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clample clample clample approved these changes

@umutuzgur umutuzgur Awaiting requested review from umutuzgur

@pilimartinez pilimartinez Awaiting requested review from pilimartinez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nahuelon @clample