Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct spelling for AssertionBuilder.responseTime() #816

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

clample
Copy link
Collaborator

@clample clample commented Aug 3, 2023

I hereby confirm that I followed the code guidelines found at engineering guidelines

Affected Components

  • CLI
  • Create CLI
  • Test
  • Docs
  • Examples
  • Other

Notes for the Reviewer

AssertionBuilder.responseTme() had a typo. This PR fixes the typo in a backwards compatible way. To avoid breaking existing projects, this PR leaves responseTme() in the codebase. This PR also marks the method as deprecated. This puts it at the bottom of the Visual Studio code suggestions.

Screenshot 2023-08-03 at 16 53 07
Screenshot 2023-08-03 at 16 48 57

@clample clample requested a review from umutuzgur August 3, 2023 14:54
Copy link
Member

@umutuzgur umutuzgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goodbye beautiful typo!

@clample clample enabled auto-merge (squash) August 3, 2023 14:55
@clample clample merged commit 70de135 into main Aug 3, 2023
3 checks passed
@clample clample deleted the chrislample/fix-response-tme-type branch August 3, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants