Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: sms & phone call alert channels optional name support [sc-00] #791

Merged
merged 2 commits into from
Jul 5, 2023
Merged

feat: sms & phone call alert channels optional name support [sc-00] #791

merged 2 commits into from
Jul 5, 2023

Conversation

maxigimenez
Copy link
Member

@maxigimenez maxigimenez commented Jul 5, 2023 •
edited by umutuzgur
Loading

I hereby confirm that I followed the code guidelines found at engineering guidelines

Affected Components

  • CLI
  • Create CLI
  • Test
  • Docs
  • Examples
  • Other

Notes for the Reviewer

Adding optional name support to SMS & Phone call constructs

umutuzgur
umutuzgur approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@umutuzgur umutuzgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxigimenez maxigimenez merged commit 8737ef5 into main Jul 5, 2023
3 checks passed
@maxigimenez maxigimenez deleted the maxigimenez/sc-00/sms-phone-call-optional-name branch July 5, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umutuzgur umutuzgur umutuzgur approved these changes

@nahuelon nahuelon Awaiting requested review from nahuelon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxigimenez @umutuzgur