Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow users to disable the schedule on deploy [gh-0] #790

Merged
merged 2 commits into from
Jul 6, 2023
Merged

fix: allow users to disable the schedule on deploy [gh-0] #790

merged 2 commits into from
Jul 6, 2023

Conversation

umutuzgur
Copy link
Member

@umutuzgur umutuzgur commented Jul 5, 2023 •
edited
Loading

I hereby confirm that I followed the code guidelines found at engineering guidelines

Affected Components

  • CLI
  • Create CLI
  • Test
  • Docs
  • Examples
  • Other

Notes for the Reviewer

Allows users to disable schedule-on-deploy

@umutuzgur umutuzgur requested a review from tnolet July 5, 2023 11:06
tnolet
tnolet approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@tnolet tnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it, this works

@umutuzgur umutuzgur merged commit fe1d4d0 into main Jul 6, 2023
3 checks passed
@umutuzgur umutuzgur deleted the umutuzgur/gh-0/allow-no-schedule-on-deploy branch July 6, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnolet tnolet tnolet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@umutuzgur @tnolet