Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): Bump @types/node from 18.11.18 to 20.3.3 #785

Merged
merged 4 commits into from
Jul 4, 2023

Conversation

danielpaulus
Copy link
Contributor

@danielpaulus danielpaulus commented Jul 4, 2023

I hereby confirm that I followed the code guidelines found at engineering guidelines

Affected Components

  • CLI
  • Create CLI
  • Test
  • Docs
  • Examples
  • Other

Notes for the Reviewer

I created a separate PR for the @types/node update. It seems to be fine and all the tests are passing. For some reason the original Dependabot PR is just missing the secrets (see screenshot) so all requests fail with HTTP 401 Unauthorized. I did not bother looking into why.
CleanShot 2023-07-04 at 10 33 45@2x

Example CI run I took the screenshot from: https://github.com/checkly/checkly-cli/actions/runs/5451590463/jobs/9918010210?pr=783

Resolves #[issue-number]

New Dependency Submission

@danielpaulus danielpaulus changed the title chore: bump up version of @types/node chore: Bump @types/node from 18.11.18 to 20.3.3 Jul 4, 2023
@danielpaulus danielpaulus changed the title chore: Bump @types/node from 18.11.18 to 20.3.3 chore(deps-dev): Bump @types/node from 18.11.18 to 20.3.3 Jul 4, 2023
@danielpaulus danielpaulus merged commit 62ddc75 into main Jul 4, 2023
3 checks passed
@danielpaulus danielpaulus deleted the danielpaulus/npm_and_yarn/types/node-20.3.3 branch July 4, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants