feat: allow --config with absolute path [gh-0] #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clample
reviewed
Mar 16, 2023
| expect(configDirectory).toEqual(pathToPosix(path.dirname(path.join(process.cwd(), configFile)))) | ||
|
|
||
| const { | ||
| config, | ||
| } = await loadChecklyConfig(path.join(__dirname, 'fixtures', 'configs'), ['good-config.js']) | ||
| } = await loadChecklyConfig(path.join(__dirname, 'fixtures', 'configs'), [filename]) |
There was a problem hiding this comment.
Why don't we pass the output of splitConfigFilePath to the loadChecklyConfig call? If the goal of the test is to make sure that splitConfigFilePath and loadChecklyConfig work nicely together, then that would make more sense to me.
With the current setup, the calls to splitConfigFilePath and loadChecklyConfig are totally separate, so it's like having two different tests. I don't think that it checks that the two work together.
clample
reviewed
Mar 16, 2023
clample
reviewed
Mar 16, 2023
clample
previously approved these changes
Mar 16, 2023
clample
previously approved these changes
Mar 16, 2023
umutuzgur
previously approved these changes
Mar 16, 2023
|
Should I approve it again? |
clample
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby confirm that I followed the code guidelines found at engineering guidelines
Affected Components
Notes for the Reviewer
--configflag--configwith absolute path.New Dependency Submission