Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use latest checkly/cli version in examples #543

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

clample
Copy link
Collaborator

@clample clample commented Feb 21, 2023

I hereby confirm that I followed the code guidelines found at engineering guidelines

Affected Components

  • CLI
  • Create CLI
  • Test
  • Docs
  • Examples
  • Other

Notes for the Reviewer

Currently the examples are set to use version ^0.3.13 of @checkly/cli. Since there isn't yet a 1.0.0 release, though, this will enforce that the version 0.3.x is used (more info). Users of npx create @checkly/cli will end up using the alpha version 0.3.15 rather than the latest version of @checkly/cli.

One fix would simply be to update the exampels to use ^0.4.0. I think that we may have trouble forgetting to keep this up-to-date, though, when 0.5.0 is released. To make sure that the examples are always using the latest CLI version, this PR simply updates them to latest for @checkly/cli.

@clample clample force-pushed the chrislample/use-latest-version-in-examples branch from 8a82a84 to b953ca4 Compare February 21, 2023 15:19
@clample clample merged commit c4e25f2 into main Feb 21, 2023
@clample clample deleted the chrislample/use-latest-version-in-examples branch February 21, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants