Skip to content

fix(base-red): prune stale ESLint suppression + align combo tests with #9630 #9774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegosouzapw merged 2 commits into from
Aug 8, 2026
Merged

fix(base-red): prune stale ESLint suppression + align combo tests with #9630 #9774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e13207
fix(quality): prune stale ESLint suppression for search.ts
diegosouzapw Aug 8, 2026
5199f46
fix(combo): align combo-routing tests with #9630 pre-dispatch skip co…
diegosouzapw Aug 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/quality/eslint-suppressions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
},
"open-sse/handlers/search.ts": {
"@typescript-eslint/no-explicit-any": {
"count": 34
"count": 33
}
},
"open-sse/handlers/sseParser.ts": {
Expand Down
4 changes: 2 additions & 2 deletions tests/unit/combo-routing-engine.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2318,7 +2318,7 @@ test("handleComboChat returns a 503 when every model is unavailable before execu

const payload = (await result.json()) as any;
assert.equal(result.status, 503);
assert.equal(payload.error.code, "ALL_ACCOUNTS_INACTIVE");
assert.equal(payload.error.code, "ALL_TARGETS_SKIPPED");
});

test("handleComboChat treats provider circuit breaker responses as ordinary target failures", async () => {
Expand Down Expand Up @@ -2847,7 +2847,7 @@ test("handleComboChat round-robin resolves nested combos and returns inactive wh

const payload = (await result.json()) as any;
assert.equal(result.status, 503);
assert.equal(payload.error.code, "ALL_ACCOUNTS_INACTIVE");
assert.equal(payload.error.code, "ALL_TARGETS_SKIPPED");
});

test("handleComboChat round-robin treats provider circuit breaker responses as ordinary target failures", async () => {
Expand Down
Loading