Skip to content

[TS7] fix(types): narrow DeepSeek tool calls - #9751

Closed
backryun wants to merge 1 commit into
cheaper-inference:release/v3.8.50from
backryun:fix/ts7-deepseek-tool-calls
Closed

backryun wants to merge 1 commit into
cheaper-inference:release/v3.8.50from
backryun:fix/ts7-deepseek-tool-calls

Conversation

@backryun

@backryun backryun commented Aug 8, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • narrow DeepSeek web assistant tool calls from unknown only after the runtime array check
  • preserve the existing prompt-building behavior for valid tool calls
  • add regression coverage for malformed non-array tool call payloads

Validation

  • node --import tsx/esm --test tests/unit/deepseek-web-tool-result-prompt-4712.test.ts tests/unit/deepseek-web-rolling-window-2942.test.ts (9/9)
  • npm run lint
  • npm run typecheck:core
  • frozen open-sse/executors/deepseek-web.ts remains 1,147 lines (no growth)
  • TypeScript 6 diagnostics: 72 -> 71, added 0
  • native TypeScript 7 diagnostics: 71 -> 70, added 0

@backryun
backryun requested a review from diegosouzapw as a code owner August 8, 2026 02:53
@backryun
backryun force-pushed the fix/ts7-deepseek-tool-calls branch 12 times, most recently from d215a6b to bbd977d Compare August 8, 2026 23:13
@diegosouzapw

Copy link
Copy Markdown
Collaborator

Thanks for the PR. Please address the mandatory items (tests and/or merge blockers) in this branch, then rerun checks before /merge-prs.

2 similar comments
@diegosouzapw

Copy link
Copy Markdown
Collaborator

Thanks for the PR. Please address the mandatory items (tests and/or merge blockers) in this branch, then rerun checks before /merge-prs.

@diegosouzapw

Copy link
Copy Markdown
Collaborator

Thanks for the PR. Please address the mandatory items (tests and/or merge blockers) in this branch, then rerun checks before /merge-prs.

@backryun
backryun force-pushed the fix/ts7-deepseek-tool-calls branch from bbd977d to 7cb3642 Compare August 9, 2026 03:43
@diegosouzapw

Copy link
Copy Markdown
Collaborator

Obrigado pelo PR. Mantive a revisão de fix-in-place e não foi possível concluir o ajuste completo aqui:

  • Para os PRs em fork: não consigo aplicar push de correção diretamente na sua branch.
    Por favor, faça um rebase/sync com release/v3.8.50, resolva conflitos se houver, e rode os checks dessa branch.
    Se preferir, posso aplicar a correção na próxima rodada assim que você mandar o branch atualizado ou confirmar que o PR está limpo pra esse merge.

@backryun
backryun force-pushed the fix/ts7-deepseek-tool-calls branch from 7cb3642 to 9b2d54a Compare August 9, 2026 04:30
@backryun

backryun commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

Updated as requested: this branch has been rebased onto the current release/v3.8.50 head (aae408f5) with no conflicts. GitHub now reports the PR as mergeable, and the branch update has restarted the checks. The branch is clean and ready for the next /merge-prs round.

@backryun
backryun force-pushed the fix/ts7-deepseek-tool-calls branch from 9b2d54a to 06b3c06 Compare August 9, 2026 09:11
@backryun

backryun commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

This patch was integrated into release/v3.8.50 through the maintainer-executed cherry-pick PR #9860. The upstream patch-id is identical, so this original PR is now superseded and can be closed.

@backryun backryun closed this Aug 9, 2026
@backryun
backryun deleted the fix/ts7-deepseek-tool-calls branch August 9, 2026 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants