Repository navigation
Conversation
hartmark
force-pushed
the
feat/chat-log-array-tail-items
branch
from
August 8, 2026 11:41
b09de9e to
5a2947e
Compare
Real agentic CLIs with many MCP servers routinely declare 40-50+ tools in a single request — a live OpenClaw session logged 47. The tail-24 default silently dropped the array's earlier entries behind an _omniroute_truncated_array marker, so investigating why a specific tool call (apply_patch) behaved oddly turned up nothing: its declared shape (function vs custom type) was unrecoverable from the call log across 40 recent requests, even though the calls themselves succeeded. Bumped the configurable default to comfortably cover real large tool lists with headroom. Updated .env.example and docs/reference/ ENVIRONMENT.md to match (env-doc-sync check passes).
The bump commit had no dedicated test asserting the literal default value; the existing chatcore-log-truncation.test.ts derives its expectations from getChatLogArrayTailItems() itself, so it can't discriminate a regression back toward the old, too-small 24 default.
hartmark
force-pushed
the
feat/chat-log-array-tail-items
branch
from
August 8, 2026 13:59
5a2947e to
a7891dc
Compare
Collaborator
|
Thanks for the PR. Please address the mandatory items (tests and/or merge blockers) in this branch, then rerun checks before /merge-prs. |
2 similar comments
Collaborator
|
Thanks for the PR. Please address the mandatory items (tests and/or merge blockers) in this branch, then rerun checks before /merge-prs. |
Collaborator
|
Thanks for the PR. Please address the mandatory items (tests and/or merge blockers) in this branch, then rerun checks before /merge-prs. |
Collaborator
|
Obrigado pelo PR. Mantive a revisão de
|
Contributor
Author
|
Code landed in #9864 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Real agentic CLIs with many MCP servers routinely declare 40-50+ tools in a single request — a live OpenClaw session logged 47. The tail-24 default silently dropped the array's earlier entries behind an
_omniroute_truncated_arraymarker, so investigating why a specific tool call (apply_patch) behaved oddly turned up nothing: its declared shape (function vs custom type) was unrecoverable from the call log across 40 recent requests, even though the calls themselves succeeded.Bumped the configurable default to comfortably cover real large tool lists with headroom. Updated
.env.exampleanddocs/reference/ENVIRONMENT.mdto match (env-doc-sync check passes).Test plan
tests/unit/chat-log-array-tail-items-default.test.tspins the literal default (24 -> 128) — confirmed failing on a cleanrelease/v3.8.50checkout, passing after. (The original commit had no dedicated test; the pre-existingchatcore-log-truncation.test.tsderives its own expectations fromgetChatLogArrayTailItems()so it can't discriminate this specific regression.)npm run typecheck:core— cleannpm run lint— cleannpm run check:file-size— clean