Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/fixes/9730-persist-rtk-renderers.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- fix(compression): persist `enableRenderers` through `normalizeRtkConfig` so RTK renderer settings survive a DB round-trip ([#9730](https://github.com/diegosouzapw/OmniRoute/pull/9730))
4 changes: 4 additions & 0 deletions src/lib/db/compression.ts
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,10 @@ function normalizeRtkConfig(value: unknown): RtkConfig {
typeof record.applyToAssistantMessages === "boolean"
? record.applyToAssistantMessages
: DEFAULT_RTK_CONFIG.applyToAssistantMessages,
enableRenderers:
typeof record.enableRenderers === "boolean"
? record.enableRenderers
: (DEFAULT_RTK_CONFIG.enableRenderers ?? false),
enabledFilters: Array.isArray(record.enabledFilters)
? record.enabledFilters.filter((filter): filter is string => typeof filter === "string")
: DEFAULT_RTK_CONFIG.enabledFilters,
Expand Down
44 changes: 44 additions & 0 deletions tests/unit/compression/rtk-renderers-config.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
import { describe, it, afterEach, after } from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";

import { rtkConfigSchema } from "../../../src/shared/validation/compressionConfigSchemas.ts";
import { DEFAULT_RTK_CONFIG } from "../../../open-sse/services/compression/types.ts";

const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-rtk-renderers-"));
const ORIGINAL_DATA_DIR = process.env.DATA_DIR;
process.env.DATA_DIR = TEST_DATA_DIR;

const core = await import("../../../src/lib/db/core.ts");
const { getCompressionSettings, updateCompressionSettings } =
await import("../../../src/lib/db/compression.ts");

describe("RTK renderer config persistence", () => {
afterEach(() => {
core.resetDbInstance();
});

after(() => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true });
if (ORIGINAL_DATA_DIR === undefined) delete process.env.DATA_DIR;
else process.env.DATA_DIR = ORIGINAL_DATA_DIR;
});

it("accepts enableRenderers on the strict write schema", () => {
assert.equal(rtkConfigSchema.safeParse({ enableRenderers: true }).success, true);
});

it("preserves enableRenderers through a fresh DB read", async () => {
const settings = await updateCompressionSettings({
rtkConfig: { ...DEFAULT_RTK_CONFIG, enableRenderers: true },
});
assert.equal(settings.rtkConfig.enableRenderers, true);

core.resetDbInstance();
const reread = await getCompressionSettings();
assert.equal(reread.rtkConfig.enableRenderers, true);
});
});