Repository navigation
fix(providers): support data URL icons - #9555
Merged
diegosouzapw merged 1 commit intoAug 10, 2026
Merged
diegosouzapw merged 1 commit into
diegosouzapw merged 1 commit into
Conversation
xz-dev
force-pushed
the
fix/provider-icon-data-urls
branch
from
August 6, 2026 05:31
43af7e0 to
3b44b54
Compare
Collaborator
|
Thanks for the PR. Please address the mandatory items (tests and/or merge blockers) in this branch, then rerun checks before /merge-prs. |
3 similar comments
Collaborator
|
Thanks for the PR. Please address the mandatory items (tests and/or merge blockers) in this branch, then rerun checks before /merge-prs. |
Collaborator
|
Thanks for the PR. Please address the mandatory items (tests and/or merge blockers) in this branch, then rerun checks before /merge-prs. |
Collaborator
|
Thanks for the PR. Please address the mandatory items (tests and/or merge blockers) in this branch, then rerun checks before /merge-prs. |
Collaborator
|
Obrigado pelo PR. Mantive a revisão de
|
Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
diegosouzapw
force-pushed
the
fix/provider-icon-data-urls
branch
from
August 10, 2026 06:22
3b44b54 to
a6d9687
Compare
diegosouzapw
merged commit Aug 10, 2026
2e6c151
into
cheaper-inference:release/v3.8.50
2 of 5 checks passed
4 of 6 tasks
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…inference#9555) Co-authored-by: xz-dev <xz-dev@users.noreply.github.com> Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data:image/*;base64,...values for compatible-provider Icon URLs while preserving HTTP(S) supportRelated Issues
Validation
Choose the change type and focused loop from the
Contribution Golden Path. The full unit suite,
Vitest, the 60% coverage gate, and the production build all run in CI on this PR (#8329):
npm run lint(changed TypeScript files via ESLint; full lint runs in CI)Focused validation:
node --import tsx/esm --test tests/unit/provider-icon-url-validator.test.ts tests/unit/provider-node-icon-url.test.tsnpx vitest run tests/unit/ui/add-compatible-provider-icon-url.test.tsx tests/unit/ui/edit-compatible-node-icon-url.test.tsxnpm run typecheck:core--no-cachenpm run i18n:checknpm run i18n:check-ui-coveragenpm run i18n:check-value-driftnpm run i18n:check-glossaryTests Added Or Updated
tests/unit/provider-icon-url-validator.test.tstests/unit/provider-node-icon-url.test.ts(existing route/DB coverage rerun)tests/unit/ui/add-compatible-provider-icon-url.test.tsxtests/unit/ui/edit-compatible-node-icon-url.test.tsxCoverage Notes
The shared validator tests cover HTTP(S), case-insensitive data-URL metadata, MIME parameters, strict base64 validation, unsafe schemes, and independent HTTP/data size caps. Existing provider-node tests cover schema, route, and SQLite persistence. Add/Edit modal tests cover inline rejection and valid data-image submission.
Reviewer Notes
TEXTcolumn stores the validated value unchanged.