Repository navigation
fix(tests): clear the two base-reds on release/v3.8.50 - #9488
Merged
Merged
Conversation
Both sat on the release itself and turned every open PR red as soon as it merged the release, independently of the PR's own content. - tests/snapshots/provider/translate-path.json: #9064 (b050164) added the code-execution-2025-08-25 and skills-2025-10-02 beta flags to the Anthropic header but did not regenerate the golden. provider-translate-path-golden failed on the bare release tip — 2 pass / 1 fail with zero PRs boarded. Regenerated; the diff is 24 lines, all the same header in 6 variants. - tests/unit/v1-models-auth-leak-9320.test.ts:83: shipped a (k: any) in a file new enough that eslint-suppressions.json does not cover it. With @typescript-eslint/no-explicit-any as error under tests/, that one cast failed 'No new ESLint warnings' for every PR. The callback parameter infers correctly, so the cast was redundant. Verified on the fix branch: eslint exit 0, typecheck:core exit 0, and both test files green (5/5).
A full-repo lint on this branch surfaced one more file in the same class: tests/unit/issue-9407-gemini-web-validation-false-positive.test.ts:50 casts (executor as any).testConnection. The file entered the release at f1ea77f (23:28), newer than the frozen eslint-suppressions.json, so the cast is not covered — and it alone kept 'No new ESLint warnings' red on this very PR. testConnection is a declared public method on GeminiWebExecutor (open-sse/executors/gemini-web.ts:359), so the cast was redundant rather than load-bearing; removed outright. eslint exit 0, typecheck:core exit 0, 15/15 across the three touched tests.
This was referenced Aug 5, 2026
diegosouzapw
added a commit
that referenced
this pull request
Aug 5, 2026
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…ence#9488) * fix(tests): clear the two base-reds on release/v3.8.50 Both sat on the release itself and turned every open PR red as soon as it merged the release, independently of the PR's own content. - tests/snapshots/provider/translate-path.json: cheaper-inference#9064 (942e9d2) added the code-execution-2025-08-25 and skills-2025-10-02 beta flags to the Anthropic header but did not regenerate the golden. provider-translate-path-golden failed on the bare release tip — 2 pass / 1 fail with zero PRs boarded. Regenerated; the diff is 24 lines, all the same header in 6 variants. - tests/unit/v1-models-auth-leak-9320.test.ts:83: shipped a (k: any) in a file new enough that eslint-suppressions.json does not cover it. With @typescript-eslint/no-explicit-any as error under tests/, that one cast failed 'No new ESLint warnings' for every PR. The callback parameter infers correctly, so the cast was redundant. Verified on the fix branch: eslint exit 0, typecheck:core exit 0, and both test files green (5/5). * fix(tests): drop a third unsuppressed any (gemini-web validation test) A full-repo lint on this branch surfaced one more file in the same class: tests/unit/issue-9407-gemini-web-validation-false-positive.test.ts:50 casts (executor as any).testConnection. The file entered the release at 00c9c6d (23:28), newer than the frozen eslint-suppressions.json, so the cast is not covered — and it alone kept 'No new ESLint warnings' red on this very PR. testConnection is a declared public method on GeminiWebExecutor (open-sse/executors/gemini-web.ts:359), so the cast was redundant rather than load-bearing; removed outright. eslint exit 0, typecheck:core exit 0, 15/15 across the three touched tests.
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
… current source constants (cheaper-inference#8901) Closes cheaper-inference#8901\n\nAlready fixed in base by PRs cheaper-inference#9224 and cheaper-inference#9488. Changelog fragment documents the fix for release notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commit message — regenerates the stale provider translate-path golden (#9064 added beta flags without updating it) and drops a redundant
(k: any)that failsNo new ESLint warningsrepo-wide.