Repository navigation
fix(translator): thread model through normalizeResponsesReasoningEffort in promotion path (#8997) - #9361
Merged
diegosouzapw merged 2 commits intoAug 8, 2026
Conversation
…rt in promotion path (#8997) The Responses-to-Chat promotion path in openaiResponsesToOpenAIRequest called normalizeResponsesReasoningEffort without the model argument, so GPT-5.6 Sol/Terra/Luna requests with reasoning.effort: "max" were downgraded to "xhigh". The model is now threaded through, preserving max for GPT-5.6 while keeping the legacy downgrade for older models. Test coverage includes all three GPT-5.6 variants (sol, terra, luna), both nested reasoning.effort and flat reasoning_effort input forms, and a guard for non-GPT-5.6 models that still get max -> xhigh.
diegosouzapw
added
the
base-red
4 of 5 tasks
Merged
12 of 13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8997
normalizeResponsesReasoningEffort was called without the model argument,
so GPT-5.6 Sol/Terra/Luna requests with reasoning.effort: "max" were
downgraded to "xhigh". The model is now threaded through, preserving