Skip to content

fix(reasoning): forward Ollama Cloud thinking - #9290

Merged
diegosouzapw merged 1 commit into
cheaper-inference:release/v3.8.50from
xz-dev:fix/ollama-cloud-responses-reasoning
Aug 4, 2026
Merged

diegosouzapw merged 1 commit into
cheaper-inference:release/v3.8.50from
xz-dev:fix/ollama-cloud-responses-reasoning

Conversation

@xz-dev

@xz-dev xz-dev commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • translate OpenAI-compatible delta.reasoning into standard streaming Responses reasoning events while preserving reasoning_content precedence
  • expose streamed reasoning through the native Ollama endpoint as message.thinking
  • make OmniRoute's registry authoritative for GPT-OSS reasoning tiers (low, medium, high) and preserve those tiers through catalog/VS Code metadata
  • verify Responses-to-Chat effort forwarding for all advertised GPT-OSS levels

Tests

  • node --import tsx/esm --test tests/unit/responses-transformer.test.ts tests/unit/translator-resp-openai-responses.test.ts tests/unit/ollama-transform.test.ts tests/unit/openai-responses-reasoning-effort.test.ts — 47 passed
  • tokenized VS Code catalog plus existing combo regressions — 38 passed
  • npm run typecheck:core
  • focused ESLint and Prettier checks for changed files
  • npm run check:file-size
  • npm run check:complexity
  • git diff --check

Baseline notes

  • npm run test:unit:fast fails identically on the untouched base and this branch under Node 26.3.0 because Next throws Invariant: AsyncLocalStorage accessed in runtime where it is not available.
  • src/app/api/v1/models/catalog.ts has an existing no-restricted-imports finding at line 3 on both the untouched base and this branch; all other changed files pass focused ESLint.

@xz-dev
xz-dev requested a review from diegosouzapw as a code owner August 3, 2026 12:13
@diegosouzapw

Copy link
Copy Markdown
Collaborator

Merged via local merge-train on 192.168.0.113 (32 cores) @ train tip 1efacead211f446aac3146c0599eca1ca190ac4c — log /srv/omniroute-train/.claude/worktrees/train-20260804-130726-suite.log.

Green: typecheck:core, check-complexity, check-cognitive-complexity, check-changelog-integrity, test:vitest.

test:unit: 15 failures, and every one of them reproduces identically on the clean release tip with zero PRs boarded (merge-gates §3) — no new failure was introduced by this train. Thirteen are the bare-model routing assertions left stale by #9275, which intentionally moved bare gpt-5.5/gpt-5.6-sol to codex without updating the tests that encoded the old destination; two are the trailing-period message change covered by #9392. A fix for those is in flight.

For reference, check-file-size is also a pre-existing base-red on the bare tip (src/sse/handlers/chat.ts 1846>1845, open-sse/executors/base.ts 1623>1578 — identical numbers with no PRs boarded): baseline drift for the release captain, not introduced here.

@diegosouzapw
diegosouzapw merged commit 455906c into cheaper-inference:release/v3.8.50 Aug 4, 2026
15 of 16 checks passed
muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants