Repository navigation
fix(logs): avoid giant provider pills for failed auto family requests - #8867
Merged
diegosouzapw merged 3 commits intoJul 28, 2026
Conversation
The provider label was decided inline in handleChat, which has no test harness — the change shipped untested and pushed chat.ts over its frozen size (1848 > 1845). Moved to rejectedRequestUsage.ts next to summarizeComboAttemptedModels, the helper it replaces on this path. chat.ts shrinks back under its baseline (no rebaseline needed) and the logic gets three cases in the suite that already covers its sibling: auto/* collapses to "auto", a named combo keeps its name, and bare "auto" (no slash) is NOT collapsed — that one is a combo request, not a family request. Also rebased on the current release tip and added the changelog fragment. Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
diegosouzapw
merged commit Jul 28, 2026
66997a6
into
cheaper-inference:release/v3.8.49
5 checks passed
diegosouzapw
added a commit
that referenced
this pull request
Jul 28, 2026
[3.8.49]: 1178 -> 1179 bullets. [3.8.47] untouched at 234. 42 i18n mirrors synced.
Merged
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…cheaper-inference#8867) * fix(logs): avoid giant provider pills for failed auto family requests * refactor(logs): extract resolveRejectedComboProvider + cover it The provider label was decided inline in handleChat, which has no test harness — the change shipped untested and pushed chat.ts over its frozen size (1848 > 1845). Moved to rejectedRequestUsage.ts next to summarizeComboAttemptedModels, the helper it replaces on this path. chat.ts shrinks back under its baseline (no rebaseline needed) and the logic gets three cases in the suite that already covers its sibling: auto/* collapses to "auto", a named combo keeps its name, and bare "auto" (no slash) is NOT collapsed — that one is a combo request, not a family request. Also rebased on the current release tip and added the changelog fragment. Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com> --------- Co-authored-by: diegosouzapw <diegosouzapw@users.noreply.github.com> Co-authored-by: rafaeldrincon <rafaeldrincon@users.noreply.github.com> Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…drincon [3.8.49]: 1178 -> 1179 bullets. [3.8.47] untouched at 234. 42 i18n mirrors synced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Failed
auto/<family>requests currently write the attempted model list intocall_logs.provider:cerebras/gemma-4-31b, nvidia/google/gemma-4-31b-it, ...lmarena/gemini-3.1-flash-lite, ...The logs page uses
providerto build quick-filter pills, so one failedauto/gemmaorauto/geminirequest creates a giant provider chip that floods the filter row.Root Cause
src/sse/handlers/chat.tscallsrecordRejectedRequestUsage()on combo failures and passes:That helper joins every attempted model with
,.Fix
For rejected combo requests, keep
providershort and categorical:autoforauto/*failurescombo.namefor other combo failurescomboThis preserves the logs UI provider filter semantics and avoids giant pills. The detailed failure info is still carried by the error/combo fields.
Verified
Locally verified against failing
auto/geminirequests: newcall_logsrows now storeprovider = "auto"instead of the comma-joined candidate list.