Repository navigation
fix(adobe-firefly): default gpt-image detailLevel to maximal (5) - #8863
Merged
diegosouzapw merged 3 commits intoJul 28, 2026
Conversation
GPT Image 2 quality is dominated by generationSettings.detailLevel (1-5). The SPA often defaults to 3 (medium); missing/auto quality previously mapped to 3 as well. Default now to 5 (high/max) so API clients and Media without an explicit quality still get maximal detail. Explicit low/medium still honored.
adobeFireflyClient.ts 2317->2322 (+5) — this PR's own growth at the existing payload-build site. Covered by tests/unit/adobe-firefly.test.ts. Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
# Conflicts: # config/quality/file-size-baseline.json
diegosouzapw
merged commit Jul 28, 2026
fff11cb
into
cheaper-inference:release/v3.8.49
5 checks passed
diegosouzapw
added a commit
that referenced
this pull request
Jul 28, 2026
…redited) Second aggregation pass, for the PRs merged after the main reconciliation: #8860, #8861, #8862, #8863, #8865, #8866. The `### 📝 Maintenance` heading added to the living section in 26a7783 held — [3.8.47] stays at its 234 bullets instead of absorbing this cycle's maintenance entries. Credits attached where the fragment carried the number only in its filename: @HouMinXi (#8860, #8865), @artickc (#8863), @rafaeldrincon (#8866). #8862 already carried its own link and credit. [3.8.49]: 1172 -> 1178 bullets · contributors 155 -> 156 · 42 i18n mirrors synced.
Merged
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…aper-inference#8863) * fix(adobe-firefly): default gpt-image detailLevel to maximal (5) GPT Image 2 quality is dominated by generationSettings.detailLevel (1-5). The SPA often defaults to 3 (medium); missing/auto quality previously mapped to 3 as well. Default now to 5 (high/max) so API clients and Media without an explicit quality still get maximal detail. Explicit low/medium still honored. * chore(quality): rebaseline adobeFireflyClient + changelog fragment adobeFireflyClient.ts 2317->2322 (+5) — this PR's own growth at the existing payload-build site. Covered by tests/unit/adobe-firefly.test.ts. Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com> --------- Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com> Co-authored-by: diegosouzapw <diegosouzapw@users.noreply.github.com>
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…redited) Second aggregation pass, for the PRs merged after the main reconciliation: cheaper-inference#8860, cheaper-inference#8861, cheaper-inference#8862, cheaper-inference#8863, cheaper-inference#8865, cheaper-inference#8866. The `### 📝 Maintenance` heading added to the living section in ae5bf9e held — [3.8.47] stays at its 234 bullets instead of absorbing this cycle's maintenance entries. Credits attached where the fragment carried the number only in its filename: @HouMinXi (cheaper-inference#8860, cheaper-inference#8865), @artickc (cheaper-inference#8863), @rafaeldrincon (cheaper-inference#8866). cheaper-inference#8862 already carried its own link and credit. [3.8.49]: 1172 -> 1178 bullets · contributors 155 -> 156 · 42 i18n mirrors synced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GPT Image 2 (and other Firefly gpt-image family models) send
generationSettings.detailLevel(integer 1–5) ongenerate-async. Output quality is dominated by this field.Problem
detailLevel: 3(medium).and mappedauto` → 3 as well.quality(or sendauto) therefore received mid-tier detail even though max (5) is available and preferred for GPT Image 2.Change
gptDetailLevel()inadobeFireflyClient.ts:auto/high/4k/ultra/ unknown → 5medium/2k/standard/hd/3→ 3low/1k/1→ 1detailLevelwas already wired into the gpt-image payload path (buildAdobeImagePayload); this only changes the default to maximal.Tests
node --import tsx --test tests/unit/adobe-firefly.test.ts→ 41/41 PASSScope
qualitymapping remains.