Repository navigation
fix(types): align web fallback contracts - #8819
Merged
diegosouzapw merged 1 commit intoJul 28, 2026
Merged
diegosouzapw merged 1 commit into
diegosouzapw merged 1 commit into
Conversation
backryun
force-pushed
the
chore/ts7-types-web-fallback-contracts
branch
from
July 28, 2026 01:51
5cc23ad to
0c6a540
Compare
diegosouzapw
merged commit Jul 28, 2026
6133939
into
cheaper-inference:release/v3.8.49
14 of 16 checks passed
Merged
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toolsandtool_choicefields used by both fallback body transformerstargetFormataccepted by its callerRoot cause
Both structural-twin modules constrained their generic request body only as
Record<string, unknown>. That permits indexed reads but does not guarantee a namedtool_choiceproperty on the generic result when the transformer rewrites it. Their preparation options also allowed an omittedtargetFormat, while the bypass predicate receiving the same object declared that field as required.Diagnostics
Re-measured after rebasing onto
release/v3.8.49atd6c06932e:141 → 137140 → 136Validation
npm run typecheck:corenpx eslint open-sse/services/webFetchInterception.ts open-sse/services/webSearchFallback.tsnpm run check:file-sizegit diff --checkNo new runtime test is needed because this is a type-only contract correction and the existing focused suites cover native bypass, flat/nested tool shapes,
tool_choicerewriting, opt-in behavior, and byte-identical no-op paths.CI note
The new release root includes the
pack-artifact-policy.test.tsfixture fix, and that focused test now passes. The unrelatedProviderAccountRoutingCard.tsx:87hook-dependency ESLint error still reproduces on the base; this PR does not touch that area.