Repository navigation
[v3.8.50] feat(combo): add maxContextWindow to contextRequirements (fixes #8777) - #8790
Conversation
Heads-up: this PR is running against a stale base
I verified this on a clean checkout of the current tip ( Currently failing here:
Please update the branch (the Update branch button, or rebase onto Note this is not a promise that every red disappears — a failure specific to the changes in this PR will survive the rebase, and No action was taken on this PR beyond this comment. |
|
Re-homed to |
Adds maxContextWindow support to combo target context filtering and validation schema.
dc3b0e7 to
4540a75
Compare
…tWindow Adds a regression test proving that when the new maxContextWindow filter (#8790) rejects every combo target, resolveComboTargetPipeline surfaces the existing #8786 context_requirements_exhausted 404 early response instead of letting an empty orderedTargets[] fall through to the attempt loop. Verified red-first by temporarily disabling the maxContextWindow filtering block in contextRequirements.ts. Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
|
Heads-up on the issue reference, not on the change itself: this PR says it fixes #8777, but #8777 is about The change itself looks fine and stands on its own; could you update the reference to the issue it actually addresses (or drop the For context: I re-triaged #8777 today and confirmed two of its defects with a reproduction test — |
8a7b246
into
cheaper-inference:release/v3.8.50
…ixes cheaper-inference#8777) (cheaper-inference#8790) Validated in local merge-train T6 (ungrouped batch 1)
Summary
Fixes #8777.
Adds
maxContextWindowsupport tocontextRequirementsin combo target filtering and validation schemas.Changes
maxContextWindow(number between 0 and 10,000,000) tocomboRuntimeConfigSchemainsrc/shared/validation/schemas/combo.tsandDEFAULT_COMBO_CONFIGinopen-sse/services/comboConfig.ts.applyContextRequirementsinopen-sse/services/combo/contextRequirements.tsto filter out targets with context windows exceedingmaxContextWindow. RespectscontextFilterMode(strictexcludes models with unknown limits,lenientincludes them).tests/unit/combo-context-requirements.test.tsandtests/unit/combo/context-requirements-integration.test.ts.