Repository navigation
[v3.8.50] fix(open-sse): filter non-numeric values in comboTargetLimits before min calculation - #8774
Conversation
Heads-up: this PR is running against a stale base
I verified this on a clean checkout of the current tip ( Currently failing here:
Please update the branch (the Update branch button, or rebase onto Note this is not a promise that every red disappears — a failure specific to the changes in this PR will survive the rebase, and No action was taken on this PR beyond this comment. |
|
Re-homed to |
…min calculation When combo targets are passed as objects, Array.prototype.map can yield undefined or non-number elements, causing Math.min to evaluate to NaN and logging 'Failed to resolve combo limits for compression: TypeError: Cannot read properties of undefined'. This fix ensures comboTargetLimits are filtered to valid numbers before calling resolveComboContextLimit and adds defense-in-depth in resolveComboContextLimit.
b907158 to
8cf5b47
Compare
…re.ts file-size cap Co-authored-by: Dingding-leo <Dingding-leo@users.noreply.github.com>
1e55fbd
into
cheaper-inference:release/v3.8.50
…ts before min calculation (cheaper-inference#8774) Validated in post-merge-train sweep (boards clean on release/v3.8.50 tip)
Summary
Filters non-numeric values in comboTargetLimits before min calculation.