Skip to content

[v3.8.50] fix(open-sse): filter non-numeric values in comboTargetLimits before min calculation - #8774

Merged
diegosouzapw merged 2 commits into
cheaper-inference:release/v3.8.50from
Dingding-leo:fix/combo-limits-type-error
Aug 6, 2026
Merged

diegosouzapw merged 2 commits into
cheaper-inference:release/v3.8.50from
Dingding-leo:fix/combo-limits-type-error

Conversation

@Dingding-leo

@Dingding-leo Dingding-leo commented Jul 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Filters non-numeric values in comboTargetLimits before min calculation.

Copilot AI review requested due to automatic review settings July 27, 2026 16:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Dingding-leo Dingding-leo changed the title fix(open-sse): filter non-numeric values in comboTargetLimits before min calculation (fixes #8769) fix(open-sse): filter non-numeric values in comboTargetLimits before min calculation Jul 27, 2026
@diegosouzapw diegosouzapw changed the title fix(open-sse): filter non-numeric values in comboTargetLimits before min calculation [v3.8.50] fix(open-sse): filter non-numeric values in comboTargetLimits before min calculation Jul 28, 2026
@diegosouzapw diegosouzapw added the deferred-v3.8.50 Adiada para o ciclo v3.8.50 (validacao VPS, refactor, ou escopo grande) label Jul 28, 2026
@diegosouzapw

Copy link
Copy Markdown
Collaborator

Heads-up: this PR is running against a stale base

release/v3.8.49 has moved 95 commits ahead of the base this PR was last built against, and several gate failures that were red on the older base have since been repaired on the branch itself:

Gate class Repaired by
No new ESLint warnings (exit 2 — orphaned suppressions, not a lint violation) #8706, #8831
Fast Quality Gates / check:file-size / Quality Ratchet #8585, #8767, plus the post-merge-train re-pins
Docs Gates (fast-path) (missing Polish API_REFERENCE) #8831
backoff-clamp + compressionDetailNormalizers unit tests #8706

I verified this on a clean checkout of the current tip (3b515d90b3): lint:json --max-warnings 0, check:file-size, check:docs-sync, error-classification.test.ts (24/24) and check-db-rules.test.ts (22/22) all pass with no changes.

Currently failing here:

  • Docs Gates (fast-path)
  • Unit Tests fast-path (2/4)
  • Unit Tests fast-path (3/4)
  • Unit Tests fast-path (4/4)

Please update the branch (the Update branch button, or rebase onto origin/release/v3.8.49) and let CI re-run. That should clear any failure caused by the stale base.

Note this is not a promise that every red disappears — a failure specific to the changes in this PR will survive the rebase, and Build (advisory) is advisory and does not block. Rebasing just removes the noise so what is left is actually yours.

No action was taken on this PR beyond this comment.

@diegosouzapw
diegosouzapw changed the base branch from release/v3.8.49 to release/v3.8.50 July 28, 2026 18:40
@diegosouzapw

Copy link
Copy Markdown
Collaborator

Re-homed to release/v3.8.50: v3.8.49 entered its release freeze, so the branch now belongs to the release captain and development continues on the next cycle. Nothing is wrong with this PR — it just needed a live base. No action needed from you; CI will re-run against the new base.

…min calculation

When combo targets are passed as objects, Array.prototype.map can yield undefined or non-number elements, causing Math.min to evaluate to NaN and logging 'Failed to resolve combo limits for compression: TypeError: Cannot read properties of undefined'. This fix ensures comboTargetLimits are filtered to valid numbers before calling resolveComboContextLimit and adds defense-in-depth in resolveComboContextLimit.
@diegosouzapw
diegosouzapw force-pushed the fix/combo-limits-type-error branch from b907158 to 8cf5b47 Compare August 4, 2026 12:04
…re.ts file-size cap

Co-authored-by: Dingding-leo <Dingding-leo@users.noreply.github.com>
@diegosouzapw
diegosouzapw merged commit 1e55fbd into cheaper-inference:release/v3.8.50 Aug 6, 2026
5 checks passed
muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
…ts before min calculation (cheaper-inference#8774)

Validated in post-merge-train sweep (boards clean on release/v3.8.50 tip)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deferred-v3.8.50 Adiada para o ciclo v3.8.50 (validacao VPS, refactor, ou escopo grande)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants