Skip to content

fix(oauth): show GitLab Duo setup before authorize error - #8710

Merged
diegosouzapw merged 2 commits into
cheaper-inference:release/v3.8.49from
DinonowDev:fix/8688-gitlab-duo-oauth-setup
Jul 27, 2026
Merged

diegosouzapw merged 2 commits into
cheaper-inference:release/v3.8.49from
DinonowDev:fix/8688-gitlab-duo-oauth-setup

Conversation

@DinonowDev

Copy link
Copy Markdown
Contributor

Surface the OAuth app registration and env-var recipe in the Add Connection modal before auto-starting authorize, and keep the same shared copy for catalog authHint and the authorize fallback (#8688).

Summary

  • Describe the user-facing or operational change.

Related Issues

  • Closes #
  • Related to #

Validation

Run only the focused loop for what you changed — the full unit suite, Vitest, the
60% coverage gate, and the production build all run in CI on this PR (#8329):

  • Focused tests for the change: node --import tsx/esm --test tests/unit/<file>.test.ts
  • npm run lint
  • Production-code changes include a new or updated automated test in this PR
  • SonarQube PR analysis is green or any remaining issues are explicitly documented below

Tests Added Or Updated

  • List every changed or added automated test file.
  • If no production code changed, state that here.

Coverage Notes

  • If this PR changes src/, open-sse/, electron/, or bin/, explain which tests cover the change.
  • If coverage moved down in any touched file, explain why and what follow-up task will recover it.

Reviewer Notes

  • Call out any risky areas, migrations, feature flags, or manual validation that reviewers should know about.

Surface the OAuth app registration and env-var recipe in the Add
Connection modal before auto-starting authorize, and keep the same
shared copy for catalog authHint and the authorize fallback (cheaper-inference#8688).
@DinonowDev
DinonowDev requested a review from diegosouzapw as a code owner July 26, 2026 18:32
…rence#8688

Extract waiting/error panels so the GitLab Duo setup step does not
trip the Fast Quality Gates file-size ratchet, and update the retry
Button regression guard for the extracted error step.
@DinonowDev
DinonowDev force-pushed the fix/8688-gitlab-duo-oauth-setup branch from ac23655 to ad40b74 Compare July 26, 2026 21:27
@diegosouzapw
diegosouzapw merged commit ba28e49 into cheaper-inference:release/v3.8.49 Jul 27, 2026
15 checks passed
HouMinXi pushed a commit to HouMinXi/OmniRoute that referenced this pull request Aug 2, 2026
…erence#8710)

* fix(oauth): show GitLab Duo setup before authorize error

Surface the OAuth app registration and env-var recipe in the Add
Connection modal before auto-starting authorize, and keep the same
shared copy for catalog authHint and the authorize fallback (cheaper-inference#8688).

* fix(oauth): keep OAuthModal under file-size baseline for cheaper-inference#8688

Extract waiting/error panels so the GitLab Duo setup step does not
trip the Fast Quality Gates file-size ratchet, and update the retry
Button regression guard for the extracted error step.
muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
…erence#8710)

* fix(oauth): show GitLab Duo setup before authorize error

Surface the OAuth app registration and env-var recipe in the Add
Connection modal before auto-starting authorize, and keep the same
shared copy for catalog authHint and the authorize fallback (cheaper-inference#8688).

* fix(oauth): keep OAuthModal under file-size baseline for cheaper-inference#8688

Extract waiting/error panels so the GitLab Duo setup step does not
trip the Fast Quality Gates file-size ratchet, and update the retry
Button regression guard for the extracted error step.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants