Repository navigation
fix(executors): pass TimeoutError reason to controller.abort() in 7 niche executors - #8699
Merged
Merged
Conversation
Collaborator
Author
|
Bom trabalho — adicionar Approving as |
3 of 4 tasks
HouMinXi
pushed a commit
to HouMinXi/OmniRoute
that referenced
this pull request
Aug 2, 2026
…iche executors (cheaper-inference#8699) Co-authored-by: ikelvingo <im.kelvinwong@gmail.com>
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…iche executors (cheaper-inference#8699) Co-authored-by: ikelvingo <im.kelvinwong@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Seven niche executors call
controller.abort()without a reason on their internal timeouts. Node.js 22 producesDOMException { name: "AbortError", message: "This operation was aborted" }.isLocalStreamLifecycleError()matchesname === "AbortError"then status 499/"Request aborted" instead of 504/"Gateway Timeout".Downstream impact: combo routing sees 499 then stops immediately, no fallback, no cooldown, no breaker. The TimeoutError path in chatCore.ts (lines 3231-3248) is never reached.
NOT affected:
base.tsalready passesname: "TimeoutError"as abort reason (lines 786-791) -- correctly classified as 504.Fix
Pass a
TimeoutError-shaped reason tocontroller.abort(err)in all 7 executors (9 call sites):Pattern applied (from base.ts):
Test
New regression test:
tests/unit/isLocalStreamLifecycleError-abort-shape.test.ts(6 cases).Side-finding from #8197 investigation