Repository navigation
Conversation
|
Pushed a second, separately-scoped commit ( Probed against a Max session — both identifiers are accepted and echoed back as
Updates Happy to split this into its own PR if you'd rather keep the mode fix isolated. |
search modesearch mode
Heads-up: this PR is running against a stale base
I verified this on a clean checkout of the current tip ( Currently failing here:
Please update the branch (the Update branch button, or rebase onto Note this is not a promise that every red disappears — a failure specific to the changes in this PR will survive the rebase, and No action was taken on this PR beyond this comment. |
|
Re-homed to |
… opt-in
Two small follow-ups on top of the reworked perplexity-web executor in 3.8.49.
pplx-opus still resolved to `claude48opus` / `claude48opusthinking`. Perplexity's
catalog has moved Opus to 5.0; the old preference is still accepted, so the model
answered from the previous generation without any error to hint at it. Updates
MODEL_MAP, THINKING_MAP and the catalog label, which advertised "Claude Opus 4.8"
in the dashboard.
The built-in-search hint appended to every system message is now opt-in via
OMNIROUTE_PPLX_SEARCH_HINT. Perplexity's answer engine is search-first anyway, and
for coding clients the sentence leaks into replies as meta-commentary ("I need to
search before responding per my instructions").
Tested: tests/unit/perplexity-web.test.ts (33/33), incl. two new cases covering the
Opus mapping and the hint flag in both states.
a8cfdd1 to
8c33e26
Compare
search mode…des it to CONCISE
Every catalog model (Sonnet, Opus, Gemini, GLM, Kimi, Grok, GPT-5.6) currently fails
with "Error in processing query." Perplexity no longer treats mode:"search" as Pro
Search: it downgrades the turn to CONCISE, drops model_preference and finishes the
stream with status:"FAILED". Only mode:"copilot" still honours a model choice.
Captured from the live endpoint on a paid account (subscription_tier:"max",
payment_tier:"paid"), same query, same cookie, only the mode differs:
mode:"search" + claude50sonnet -> {"text":"Error in processing query.",
"mode":"CONCISE","status":"FAILED"}
mode:"copilot" + claude50sonnet -> {"mode":"COPILOT",
"display_model":"claude50sonnet"} + stream
mode:"search" + claude50opus -> {"mode":"CONCISE","status":"FAILED"}
mode:"copilot" + claude50opus -> {"mode":"COPILOT",
"display_model":"claude50opus"} + stream
pplx-auto/pplx-sonar were already on "copilot" and kept working, which is why this
is easy to miss. The THINKING_MAP branch in the executor hardcoded "search" too, so
thinking variants failed the same way.
Adds a guard test so no future entry can reintroduce "search".
Tested: tests/unit/perplexity-web.test.ts (34/34) + live requests through the
running server for pplx-auto, pplx-sonar, pplx-sonnet and pplx-opus.
8c33e26 to
eb1cbc8
Compare
Merged — extraction of the one still-uncovered fix from #8634 (the other two items — mode "search"→CONCISE downgrade, pplx-opus generation — were already applied on this release tip). typecheck/file-size/changelog/complexity/cognitive-complexity gates all clean, 32/32 tests passing.
|
Thanks — great root-causing here, with live-endpoint evidence that made this easy to verify. Auditing against the current release tip:
Given this branch was a month old and CONFLICTING against the current release, I extracted just the uncovered fix rather than trying to reconcile the whole diff. Closing as superseded by #10904 for the remaining value — full credit is there. |
…ference#10904) Merged — extraction of the one still-uncovered fix from cheaper-inference#8634 (the other two items — mode "search"→CONCISE downgrade, pplx-opus generation — were already applied on this release tip). typecheck/file-size/changelog/complexity/cognitive-complexity gates all clean, 32/32 tests passing.
Rebased onto current
main(3.8.49) and reduced to two commits. The original PR predates the perplexity-web rework, so the old diff is gone — please re-review, the substance changed.1.
mode: "search"is broken — it takes the whole catalog down3.8.49 posts
mode: "search"for every catalog model. Perplexity no longer treats that as Pro Search: it downgrades the turn to CONCISE, discardsmodel_preference, and ends the stream withstatus: "FAILED"and the text "Error in processing query."Captured against the live endpoint, paid account (
subscription_tier: "max",payment_tier: "paid",pro_search_mode: "pro"), same cookie, same query, onlymodediffers:pplx-autoandpplx-sonarwere already on"copilot"and keep working, which makes this easy to miss in a smoke test — the two models most people try first are exactly the two that are fine, while Sonnet/Opus/Gemini/GLM/Kimi/Grok/GPT-5.6 all fail.The executor's
THINKING_MAPbranch hardcoded"search"as well, so thinking variants failed the same way.This PR moves every
MODEL_MAPentry and the thinking branch to"copilot"and adds a guard test, so a future entry cannot reintroduce"search"unnoticed.2.
pplx-opuspoints at the previous Opus generationclaude48opus/claude48opusthinkingare still accepted by the backend, so there is no error — the model just answers from the older generation while the dashboard advertises it as Opus. Perplexity's catalog exposesclaude50opus; withmode:"copilot"it comes back as"display_model": "claude50opus"(see the capture above). UpdatedMODEL_MAP,THINKING_MAPand the catalog label (which read "Claude Opus 4.8").3. The built-in-search hint is now opt-in
The sentence "You have built-in web search. Answer questions directly using search results." was appended to every system message. Perplexity's answer engine searches anyway, and for coding clients it leaks into replies as meta-commentary ("I need to search before responding per my instructions"). Now behind
OMNIROUTE_PPLX_SEARCH_HINT(off by default, documented in.env.exampleanddocs/reference/ENVIRONMENT.md). Happy to drop this commit if you would rather keep the old behaviour — items 1 and 2 stand on their own.Tested
tests/unit/perplexity-web.test.ts— 34/34, including three new cases (Opus mapping, the mode guard, the hint flag in both states).pplx-auto,pplx-sonar,pplx-sonnet,pplx-opusall answer; server log showspref=claude50opus, mode=copilot. Before the fix, the same build returned "Error in processing query." forpplx-sonnetandpplx-opus.