Repository navigation
fix(api): prevent silent lost updates on concurrent settings writes (#7784) - #8587
Merged
diegosouzapw merged 1 commit intoJul 27, 2026
Conversation
…heaper-inference#7784) Add opt-in settingsRevision / If-Match optimistic concurrency so stale PATCH writers get 409 instead of silently clobbering map settings.
Prudhvivuda
force-pushed
the
fix/7784-settings-cas
branch
from
July 25, 2026 15:49
8a2c396 to
db46a89
Compare
diegosouzapw
merged commit Jul 27, 2026
4d24c0c
into
cheaper-inference:release/v3.8.49
5 checks passed
Merged
HouMinXi
pushed a commit
to HouMinXi/OmniRoute
that referenced
this pull request
Aug 2, 2026
…heaper-inference#7784) (cheaper-inference#8587) Add opt-in settingsRevision / If-Match optimistic concurrency so stale PATCH writers get 409 instead of silently clobbering map settings.
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…heaper-inference#7784) (cheaper-inference#8587) Add opt-in settingsRevision / If-Match optimistic concurrency so stale PATCH writers get 409 instead of silently clobbering map settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
settingsRevisionwithETagon GET/PATCH/api/settingsand opt-in optimistic concurrency viaexpectedRevision(body) orIf-Match(header).409 SETTINGS_REVISION_CONFLICTwhen a stale writer would clobber map keys likeproviderStrategies/wildcardAliasesinstead of silently dropping concurrent changes.expectedRevision.Test plan
node --import tsx/esm --test tests/unit/settings-cas-7784.test.ts— reproduces maintainer A/B race; stale writer gets 409 and first change is preservednode --import tsx/esm --test tests/unit/settings-api.test.ts tests/unit/api/settings-audit.test.ts— existing settings routes still passCloses #7784