Repository navigation
fix(sse): cache tls-client-node binary under DATA_DIR (#8579) - #8583
Merged
diegosouzapw merged 1 commit intoJul 27, 2026
Merged
diegosouzapw merged 1 commit into
diegosouzapw merged 1 commit into
Conversation
…ientOptions across multiple services This change modifies the instantiation of TLSClient in chatgptTlsClient, claudeTlsClient, grokTlsClient, lmarenaTlsClient, notionTlsClient, and perplexityTlsClient to utilize the new buildNativeTlsClientOptions function. This refactor enhances consistency and maintainability across the TLS client implementations.
diegosouzapw
merged commit Jul 27, 2026
eadb28c
into
cheaper-inference:release/v3.8.49
3 checks passed
Merged
HouMinXi
pushed a commit
to HouMinXi/OmniRoute
that referenced
this pull request
Aug 2, 2026
…ientOptions across multiple services (cheaper-inference#8583) This change modifies the instantiation of TLSClient in chatgptTlsClient, claudeTlsClient, grokTlsClient, lmarenaTlsClient, notionTlsClient, and perplexityTlsClient to utilize the new buildNativeTlsClientOptions function. This refactor enhances consistency and maintainability across the TLS client implementations.
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…ientOptions across multiple services (cheaper-inference#8583) This change modifies the instantiation of TLSClient in chatgptTlsClient, claudeTlsClient, grokTlsClient, lmarenaTlsClient, notionTlsClient, and perplexityTlsClient to utilize the new buildNativeTlsClientOptions function. This refactor enhances consistency and maintainability across the TLS client implementations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
downloadDirto everytls-client-nodeTLSClientbootstrap so the native binary is cached under<DATA_DIR>/tls-client/bininstead of the root-owned package path insidenode_modules.buildNativeTlsClientOptions()inopen-sse/services/tlsClientDownloadDir.tsand wire all six web-provider TLS clients through it (chatgpt-web, claude-web, grok-web, perplexity-web, lmarena, notion-web).DATA_DIRand that no TLS client constructsTLSClientwithoutdownloadDir.Fixes #8579
Root cause
On global install (
npm i -g omniroute),tls-client-nodedefaulted to downloading intonode_modules/tls-client-node/bin, which is root-owned and fails withEACCESfor normal users.Test plan
node --import tsx/esm --test tests/unit/tls-client-download-dir-8579.test.ts(3 passed)