Repository navigation
fix(quality): repair release/v3.8.49 base-red gates - #8561
diegosouzapw merged 1 commit into
Conversation
|
Thanks for the thorough writeup, and for being upfront about the overlap — "happy to fold this into either one instead" made this much easier to evaluate. I ran each of the four slices against the other open base-red PRs, on fresh worktrees off the pristine tip. Two of them decide what happens here. Slice (a), #8534 makes the same allowlist change and updates the test, so this slice should come from there instead. Slice (d), the I want to be explicit about one thing, because an earlier read of this PR got it wrong: #8532 also touches The other two slices are duplicates: (b) is functionally identical to #8539's fix, and (c) is the same one-line So the ask is a trim, not a close: drop slices (a), (b) and (c) — they're covered by #8534, #8539 and #8544 — and keep (d). That leaves a small, focused PR that unblocks the whole queue, and it avoids the test regression in (a). Your root-causing here was accurate and genuinely useful; the note you wrote into the baseline file documenting why the growth was inherited and unattributable is exactly the right thing for the next person to find. |
check:file-size fails on the pristine release/v3.8.49 tip (3070925), which takes the whole Fast Quality Gates job down for every PR against the branch. Both offenders grew after the last rebaseline (_rebaseline_2026_07_25_v3849_basered_filesize, measured at 36f8fd1) and both came from already-merged PRs, so there is no offending branch left to fix: src/lib/tokenHealthCheck.ts 841 -> 843 (cheaper-inference#8426, 4528fc4) src/app/(dashboard)/dashboard/providers/page.tsx 1927 -> 1990 (cheaper-inference#8349, 58ab8b1) Trust-but-verify: both values measured on the pristine tip with an empty working tree. Same situation and remedy as the entry cited above and as _rebaseline_2026_07_02_5798_release_green. This commit is deliberately last and self-contained: drop it if the captain would rather move the frozen values separately. Structural reduction of the 1990-line providers page is not attempted here. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
80fd898 to
6e85847
Compare
|
Following up on the review above — I went ahead and did the trim on this branch, since the file-size gate was blocking every open PR and your slice (d) was the only open fix for it. What changed: your four commits became one. I cherry-picked
Your commit is untouched and still authored by you; nothing was rewritten, only the three now-redundant commits were left out. The PR is now a single commit, one file, +4/-3. Verified on the trimmed branch against the current tip: That is all four previously-red gates green — the base had been failing Thanks for the diagnosis on this one. The part that made the difference was documenting why the growth was inherited and had no offending branch left to fix — that note in the baseline file is what the next person needs to understand why the ceiling moved. |
4053e23
into
cheaper-inference:release/v3.8.49
…er-inference#8561) check:file-size fails on the pristine release/v3.8.49 tip (df69bd1), which takes the whole Fast Quality Gates job down for every PR against the branch. Both offenders grew after the last rebaseline (_rebaseline_2026_07_25_v3849_basered_filesize, measured at d61504d) and both came from already-merged PRs, so there is no offending branch left to fix: src/lib/tokenHealthCheck.ts 841 -> 843 (cheaper-inference#8426, 903ecfa) src/app/(dashboard)/dashboard/providers/page.tsx 1927 -> 1990 (cheaper-inference#8349, e62c217) Trust-but-verify: both values measured on the pristine tip with an empty working tree. Same situation and remedy as the entry cited above and as _rebaseline_2026_07_02_5798_release_green. This commit is deliberately last and self-contained: drop it if the captain would rather move the frozen values separately. Structural reduction of the 1990-line providers page is not attempted here. Co-authored-by: alexey.nazarov@softmg.ru <alexey.nazarov@softmg.ru> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
…er-inference#8561) check:file-size fails on the pristine release/v3.8.49 tip (400757e), which takes the whole Fast Quality Gates job down for every PR against the branch. Both offenders grew after the last rebaseline (_rebaseline_2026_07_25_v3849_basered_filesize, measured at 75eb952) and both came from already-merged PRs, so there is no offending branch left to fix: src/lib/tokenHealthCheck.ts 841 -> 843 (cheaper-inference#8426, 35b6719) src/app/(dashboard)/dashboard/providers/page.tsx 1927 -> 1990 (cheaper-inference#8349, 17aed5f) Trust-but-verify: both values measured on the pristine tip with an empty working tree. Same situation and remedy as the entry cited above and as _rebaseline_2026_07_02_5798_release_green. This commit is deliberately last and self-contained: drop it if the captain would rather move the frozen values separately. Structural reduction of the 1990-line providers page is not attempted here. Co-authored-by: alexey.nazarov@softmg.ru <alexey.nazarov@softmg.ru> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Summary
release/v3.8.49is red at its own tip (30709255), so every PR against the branch inherits four failing checks regardless of content. This PR repairs what can be repaired from a contributor branch. Four commits, each independent:test(resilience)Unit Tests fast-path (1/4)— 3 assertionsfix(quality)check:db-rules+Unit Tests fast-path (2/4)chore(quality)No new ESLint warningschore(quality)Fast Quality Gates→check:file-sizeEvery claim below was measured on a pristine
origin/release/v3.8.49checkout with an empty working tree, in a worktree separate from the change.What was red and why
1. Three backoff assertions (
error-classification.test.ts,thundering-herd.test.ts)b64361dd2(#8396 / #8446) capped the scaled connection cooldown atBACKOFF_CONFIG.maxso a 429/5xx burst cannot black a connection out past the real rate-limit window. Three tests still expected uncapped doubling:The cap is intended behavior, so the expectations follow it.
newBackoffLevelclamping is untouched and still asserted.2.
compressionDetailNormalizersnot in the allowlistsrc/lib/db/compressionDetailNormalizers.tsis imported only bydb/compression.tsand exists becausecompression.tsis frozen at its file-size cap (#8388). Re-exporting it throughlocalDb.tswould advertise the barrel-import anti-pattern Hard Rule #2 forbids, soINTENTIONALLY_INTERNALis the right home. This unblocks both the gate script and its freeze-guard unit test.3. Stale ESLint suppression
npm run lint:json -- --max-warnings 0exits 2 with "There are suppressions left that do not occur anymore". Exactly one entry is stale —tests/unit/proxy-registry.test.ts,no-explicit-any55 → 54. Regenerated with--prune-suppressions; that single count is the whole diff.4. Inherited file-size growth
Both grew after the last rebaseline (
_rebaseline_2026_07_25_v3849_basered_filesize, measured at36f8fd10) and both came from already-merged PRs — #8426 (4528fc455) and #8349 (58ab8b1d2) — so there is no offending branch left to fix. Same situation and remedy as that entry and as_rebaseline_2026_07_02_5798_release_green; documented in a new_rebaseline_*key.Commit 4 is deliberately last and self-contained — drop it if you would rather move the frozen values yourself. Structural reduction of the 1990-line providers page is not attempted here.
Deliberately NOT touched: the complexity ratchet
check:complexity-ratchetsis also red on the pristine base:Per
c539d37b2("revert unauthorized ratchet rebaseline in #8306"), ratchet rebaselines are reserved for the release captain and the drift is tracked by #8254 / #8256. Left alone.Fast Quality Gateswill stay red at that step until those land — the file-size step is simply no longer the thing that kills the job first.Overlap with the open base-red slices
config/quality/eslint-suppressions.json(+7−2). Mine is a one-count prune of a different concern; trivially reconcilable either way. ItsaccountFallback/combo/reasoningPlaceholderfixes address failures that are no longer in the current red set.ladder.ts) does not overlap at all.Both are
CONFLICTINGright now, which is why the base is still red. Happy to fold this into either one instead if you prefer a single slice.Verification
Measured before and after, same machine, same Node:
30709255)check:file-sizecheck:db-ruleslint:json --max-warnings 0error-classification+thundering-herd+check-db-rulescheck:complexity-ratchetsprettier --checkclean on all touched files. No production code is modified: the diff is 2 test files, 1 gate script allowlist entry, and 2 quality baselines.