Repository navigation
Conversation
|
Thanks for taking the time to rebase this and resolve the conflicts — that work is genuinely useful, and I checked that you preserved the original commit authorship rather than re-attributing it. Here's how we're going to land it, though. #8307 (by @fenix007) is still open and is the PR that carries this change originally. If we merge this one instead, GitHub gives the "Merged" badge here and leaves #8307 stranded — the original author ends up with no credit for work that is theirs. Our contributing policy is to resolve conflicts inside the original author's branch and merge that PR. So we'll apply your conflict resolution to #8307 and merge it there. This PR is labelled To be clear: this is not a rejection of your work. The rebase you did is exactly what #8307 needed, and it's what will get pushed there. Thank you. |
|
Correcting my earlier note on this one: I re-checked directly against the current release/v3.8.49 tip and the Codex retry-by-account logic (the |
…ests into dedicated file The Codex account-fallback tests from PR cheaper-inference#8477 (rebase of cheaper-inference#8307) push the shared image-generation-route test file above the 800-line testCap from config/quality/file-size-baseline.json. Extract the 5 new tests (skips-excluded-model, retries-one-sibling, no-retry-ordinary-400, stops-after-one-fallback, attributes-call-logs) plus their shared fixtures into tests/unit/image-generation-route-codex-account-fallback.test.ts to keep both files well under the cap. No production code touched; all 21 tests still pass. Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
Heads-up: this PR is running against a stale base
I verified this on a clean checkout of the current tip ( Currently failing here:
Please update the branch (the Update branch button, or rebase onto Note this is not a promise that every red disappears — a failure specific to the changes in this PR will survive the rebase, and No action was taken on this PR beyond this comment. |
|
Re-homed to |
|
Obrigado pela entrega! Esta PR segue uma estratégia de rebase de trabalho derivado e não preserva corretamente o fluxo de crédito original para essa mudança.\n\nPara manter rastreabilidade e evitar impacto no histórico, vamos seguir pelo PR canônico.\n\nSe você quiser, pode abrir um PR novo e bem focado com a mesma correção, sem duplicação/rebase de terceiros. |
|
Closed por solicitação do maintainer: rebase de contribuição canônica em fluxo de autoria preservada. Obrigado e reabra de forma nova e focada se ainda quiser contribuir nessa mudança. |
Conflict-resolved rebase of upstream PR #8307. Cherry-picked 317799c (fix(api): retry Codex image generation by account) onto latest upstream/release/v3.8.49 (36f8fd1). No conflicts encountered.