Repository navigation
fix(ui): decouple healthy and last-routed states in ProviderTopology (Fixes #8409) - #8428
Conversation
|
Aligned with #8409. Local:
Ready for review. |
|
Thanks for the fast turnaround here — this is exactly the fix we described on #8409. I re-ran both suites on a clean checkout of your branch:
The border/dot/edge precedence traces correctly for every combination we checked, including error+last (still renders red, as your own test asserts). No changes requested — merging as-is. One heads-up unrelated to your PR: #8450 touches the same component with a different 'calm-at-rest' visual philosophy and flags the tension with this fix itself, so we'll reconcile that separately when we get to it. |
7cc922b
into
cheaper-inference:release/v3.8.49
|
Merged into |
…10900) Merged — reimplementation extracting the non-conflicting Recent Requests panel + excludeTests allowlist fix from #8450 (see PR body for the full scoping rationale, including why the topology UX rework was deliberately excluded — it contradicts the already-shipped #8428). typecheck/file-size/changelog/complexity/cognitive-complexity/i18n-coverage gates all clean, 2/2 unit + 1/1 vitest passing.
…heaper-inference#10900) Merged — reimplementation extracting the non-conflicting Recent Requests panel + excludeTests allowlist fix from cheaper-inference#8450 (see PR body for the full scoping rationale, including why the topology UX rework was deliberately excluded — it contradicts the already-shipped cheaper-inference#8428). typecheck/file-size/changelog/complexity/cognitive-complexity/i18n-coverage gates all clean, 2/2 unit + 1/1 vitest passing.
Summary
Fixes #8409
On the home Provider topology, the most recently routed node was painted as idle grey with no status dot while its edge stayed amber — health and recency were incorrectly coupled (
!lastANDed intohealthy/healthError), and the node had nolastvisual.Changes
healthy/healthErrorno longer depend on!lastlast(amber viaFLOW_EDGE_COLORS.last)Distinct from #8328 (custom nodes missing from the graph entirely).
Test plan
node --import tsx --test tests/unit/topology-connection-health.test.ts→ 4/4 passvitest run tests/unit/ui/home-topology-last-used-node-color.test.tsx→ 3/3 pass