[diegosouzapw]

Test-only PR. No production code touched.

Root causes

A — executor-notion-web-thread-sessions.test.ts hits real app.notion.com (#8159)

sendNotionInferenceRequest() in open-sse/executors/notion-web.ts was migrated from fetch() to tlsFetchNotion() (open-sse/services/notionTlsClient.ts, native tls-client-node binary, Chrome-JA3 fingerprint) to get past Notion's Cloudflare TLS fingerprinting — plain fetch() is now only a fallback path used when the native TLS client fails to load.

#8159 updated the mock in the sibling tests/unit/executor-notion-web.test.ts (added installNotionTlsMock, wired through the module's __setTlsFetchOverrideForTesting test hook) but never touched tests/unit/executor-notion-web-thread-sessions.test.ts (split out earlier by #7900 for the file-size gate). Its 3 execute()-driven tests still mocked globalThis.fetch, which tlsFetchNotion() never calls once the native TLS client loads successfully — so the mock silently stopped intercepting anything.

Confirmed live in this sandbox: all 3 tests hit real https://app.notion.com with a fake cookie and got a real 401 (AssertionError: 401 !== 200), ~8.1-8.5s each due to the real TLS handshake + round trip. On a CI runner with blocked or slow egress this would instead hang up to the client's timeout+grace window (default 180_000ms + 10_000ms grace ≈ 190s) per test instead of failing fast — a CI-hang risk, not just 3 red assertions.

B — usage-analytics-route-extra.test.ts is a stale duplicate of 10/22 tests (#7700 / #7300)

tests/unit/usage-analytics-route-extra.test.ts (added by #7700) is a byte-for-byte duplicate of 10 of the 22 tests in tests/unit/usage-analytics-route.test.ts. #7300 later fixed a fixture bug in the retention-window boundary test ("does not double-count raw and aggregated rows") only in the main file — reading getUserDatabaseSettings().retention.usageHistory live instead of hardcoding a 30-day cutoff (default retention is actually 365 days, so the hardcoded 30-day boundary put the "older" row inside the still-current retention window). The duplicate file kept the stale hardcoded 30-day value and now fails deterministically (1 !== 2).

Fix

• A: Replicated installNotionTlsMock verbatim from executor-notion-web.test.ts into executor-notion-web-thread-sessions.test.ts (same handler shape: {status, text} → {status, headers: new Headers(), text, body: null}), and swapped all 3 globalThis.fetch = ... / restore blocks for installNotionTlsMock(...) / restore(). No assertions changed — only the interception point.

• B: Deleted tests/unit/usage-analytics-route-extra.test.ts. Confirmed first, via comm -12 of the extracted test(...) names, that all 10 of its test names exist verbatim in the main file, and that the main file passes in full:

  • does not double-count raw and aggregated rows
  • does not persist guessed API key attribution
  • does not throw Unknown named parameter on short range (needsAggregated=false)
  • does not throw Unknown named parameter with apiKey filter on long range
  • groups renamed API key usage by stable ID
  • includes activityMap for heatmap
  • includes cost by API key
  • omits global aggregates when filtering by API key
  • returns 500 on database errors
  • returns weeklyPattern for the costs dashboard

  No coverage loss: same production code (src/app/api/usage/analytics/route.ts), same assertions, one fewer redundant file.

Validation

All runs: env -u OMNIROUTE_API_KEY node --import tsx/esm --test tests/unit/<file>.test.ts, sequential.

File	Before (RED)	After (GREEN)
executor-notion-web-thread-sessions.test.ts	5 pass / 3 fail (401 !== 200, real network) — 31.0s	8/8 pass — 8.0s, hermetic (no network)
executor-notion-web.test.ts (sibling, untouched)	37/37 pass — 9.3s	37/37 pass — 9.3s (byte-identical diff, re-verified)
usage-analytics-route-extra.test.ts	9 pass / 1 fail (1 !== 2) — 18.7s	(deleted)
usage-analytics-route.test.ts (untouched)	22/22 pass — 20.4s	22/22 pass — 20.4s (byte-identical diff, re-verified)

Also ran clean:

• npx eslint tests/unit/executor-notion-web-thread-sessions.test.ts — 0 errors/warnings
• npm run typecheck:core — exit 0, no errors

Refs #8159
Refs #7300
Refs #7700