Skip to content

fix(sse): preserve Responses API payloads in combos - #8310

Merged
diegosouzapw merged 1 commit into
cheaper-inference:release/v3.8.49from
ridho9:fix/responses-combo-payload
Jul 24, 2026
Merged

diegosouzapw merged 1 commit into
cheaper-inference:release/v3.8.49from
ridho9:fix/responses-combo-payload

Conversation

@ridho9

@ridho9 ridho9 commented Jul 23, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • preserve Responses API input payloads when combo middleware runs
  • map combo system_message overrides to Responses instructions instead of Chat messages
  • add regression coverage for Responses payloads with and without an override

Tests

  • node --import tsx/esm --test tests/unit/services-branch-hardening.test.ts ✅
  • npm run lint ✅
  • npm run check:changelog-integrity ✅
  • npm run test:unit ⚠️ fails in files outside this PR's diff, including an undefined PROVIDER_BREAKER_FAILURE_STATUSES in src/sse/handlers/chat.ts, environment/docs contract drift, and stale catalog/UI expectations.
  • npm run test:coverage ⚠️ exits on the same unrelated suite failures; its coverage gate passes: statements/lines 83.98%, branches 78.30%, functions 87.91% (all ≥60%).

Changed tests

  • `tests/unit/services-branch-hardening.test.ts

@ridho9
ridho9 requested a review from diegosouzapw as a code owner July 23, 2026 16:23
@ridho9
ridho9 force-pushed the fix/responses-combo-payload branch 3 times, most recently from 812eb5b to 193fe5d Compare July 23, 2026 16:37
@ridho9
ridho9 force-pushed the fix/responses-combo-payload branch from 193fe5d to 67c3d2c Compare July 23, 2026 16:38
@ridho9
ridho9 changed the base branch from main to release/v3.8.49 July 23, 2026 16:38
@diegosouzapw
diegosouzapw merged commit ddbd054 into cheaper-inference:release/v3.8.49 Jul 24, 2026
3 checks passed
@diegosouzapw

Copy link
Copy Markdown
Collaborator

Merged into release/v3.8.49 — thanks @ridho9! Validated via local merge-train (32-core .113) + a per-file discriminator confirming zero regressions vs the pure release tip; CI reds on this PR were pre-existing base-red drift (tracked separately). 🙏

@diegosouzapw diegosouzapw mentioned this pull request Jul 28, 2026
HouMinXi pushed a commit to HouMinXi/OmniRoute that referenced this pull request Aug 2, 2026
muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants