Skip to content

fix: normalize Codex URLs and dashboard regressions - #8233

Merged
diegosouzapw merged 2 commits into
cheaper-inference:release/v3.8.49from
nguyenha935:fix/codex-local-bridge-base-url
Jul 23, 2026
Merged

fix: normalize Codex URLs and dashboard regressions#8233
diegosouzapw merged 2 commits into
cheaper-inference:release/v3.8.49from
nguyenha935:fix/codex-local-bridge-base-url

Conversation

@nguyenha935

@nguyenha935 nguyenha935 commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • normalize Codex client base URLs to the bridge-compatible /v1 root
  • use the defined primary color token for analytics input bars
  • fix the two new OAuthModal.tsx dashboard typecheck regressions
  • update the Grok paste contract test to read messages from the extracted parser module
  • synchronize README compression claims and the engine table with the 12-engine catalog
  • sanitize Muse Spark fetch failures before returning them to clients

Verification

  • npm run check:dashboard-typecheck — 254 baselined errors, no new regressions
  • focused Node tests — 24 passed, 0 failed for the latest docs/Muse changes; 25 passed, 0 failed for the original dashboard regressions
  • npm run check:docs-counts
  • npm run check:error-helper
  • npm run check:file-size
  • ESLint on all changed TypeScript/TSX files
  • Prettier check on all changed files
  • changelog integrity check

No production deployment is included in this PR workflow.

CI note

The patch-specific gates pass, including docs-count sync, error-helper, file-size,
focused tests, Vitest, Semgrep, and DAST. The PR-wide workflow is currently red on
pre-existing release/v3.8.49 inconsistencies outside this PR's changed files:
13 undocumented environment variables, stale Stryker test membership, 27 unrelated
unit failures, and full-tree ESLint debt. None of the failures reference the files
changed by this PR.

@nguyenha935
nguyenha935 force-pushed the fix/codex-local-bridge-base-url branch from f4df8b6 to 4a0c104 Compare July 23, 2026 02:29
@nguyenha935
nguyenha935 marked this pull request as ready for review July 23, 2026 02:30
@nguyenha935
nguyenha935 force-pushed the fix/codex-local-bridge-base-url branch from 4a0c104 to 96ceef9 Compare July 23, 2026 02:46
@nguyenha935
nguyenha935 force-pushed the fix/codex-local-bridge-base-url branch from 96ceef9 to c4b39d6 Compare July 23, 2026 02:57
@diegosouzapw diegosouzapw mentioned this pull request Jul 23, 2026
Merged
@diegosouzapw

diegosouzapw commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Thanks, @nguyenha935! 🙏 Merged — normalizes Codex URLs + fixes the dashboard regressions. Rebased onto the current release tip (kept the release's aggregate README numbers). The one red (check-docs-counts-sync 'gate exits 0') is a pre-existing docs-count drift on the release tip — reproduced identically without this PR, so it's the README-audit's job, not this change.

@diegosouzapw
diegosouzapw merged commit a6eb4d8 into cheaper-inference:release/v3.8.49 Jul 23, 2026
2 of 5 checks passed
This was referenced Jul 23, 2026
Merged
Merged
diegosouzapw added a commit that referenced this pull request Jul 24, 2026
@diegosouzapw
chore(quality): drop stale muse-spark-web allowlist entry + sync side…
70901c0 
…bar order snapshots

Two independent "code is right, bookkeeping lagged" base-reds:

1. #8233 made open-sse/executors/muse-spark-web.ts import
   sanitizeErrorMessage from utils/error.ts (a real Rule #12 fix), but
   left its KNOWN_MISSING_ERROR_HELPER allowlist entry in
   scripts/check/check-error-helper.mjs in place. The gate's own
   stale-allowlist enforcement (assertNoStale) correctly flagged the now
   -obsolete entry: `npm run check:error-helper` failed with "1 entrada(s)
   obsoleta(s)", and tests/unit/check-error-helper.test.ts's "the shipped
   allowlist freezes exactly the known current violators" test expected
   an empty Set. Removed the entry (kept the assertNoStale machinery and
   the general scope-header comments untouched).

2. #8064 added the "compression-exclusions" sidebar item right after
   "compression-studio" in COMPRESSION_CONTEXT_GROUP (deliberate,
   complete feature) but didn't update two order-snapshot tests written
   before that item existed:
   - tests/unit/sidebar-visibility.test.ts expected the "omni-proxy"
     section's flattened id list to end the compression block at
     "compression-studio".
   - tests/unit/ui/sidebar-engine-items.test.ts asserted "Studio must be
     last" in COMPRESSION_CONTEXT_GROUP.
   Updated both to the real, intentional order: Settings -> Combos ->
   engines -> Studio -> Exclusions (Studio now second-to-last,
   Exclusions last).

Validation (red -> green):
- check:error-helper gate: red ("1 entrada(s) obsoleta(s)") -> green
  ("OK (898 files scanned, 0 known-missing frozen)")
- tests/unit/check-error-helper.test.ts: 31/32 -> 32/32
- tests/unit/sidebar-visibility.test.ts: 6/7 -> 7/7
- tests/unit/ui/sidebar-engine-items.test.ts: 13/14 -> 14/14

Refs #8233
Refs #8064
diegosouzapw added a commit that referenced this pull request Jul 24, 2026
@diegosouzapw
chore(quality): drop stale muse-spark-web allowlist entry + sync side…
875de01 
…bar order snapshots (#8383)

Two independent "code is right, bookkeeping lagged" base-reds:

1. #8233 made open-sse/executors/muse-spark-web.ts import
   sanitizeErrorMessage from utils/error.ts (a real Rule #12 fix), but
   left its KNOWN_MISSING_ERROR_HELPER allowlist entry in
   scripts/check/check-error-helper.mjs in place. The gate's own
   stale-allowlist enforcement (assertNoStale) correctly flagged the now
   -obsolete entry: `npm run check:error-helper` failed with "1 entrada(s)
   obsoleta(s)", and tests/unit/check-error-helper.test.ts's "the shipped
   allowlist freezes exactly the known current violators" test expected
   an empty Set. Removed the entry (kept the assertNoStale machinery and
   the general scope-header comments untouched).

2. #8064 added the "compression-exclusions" sidebar item right after
   "compression-studio" in COMPRESSION_CONTEXT_GROUP (deliberate,
   complete feature) but didn't update two order-snapshot tests written
   before that item existed:
   - tests/unit/sidebar-visibility.test.ts expected the "omni-proxy"
     section's flattened id list to end the compression block at
     "compression-studio".
   - tests/unit/ui/sidebar-engine-items.test.ts asserted "Studio must be
     last" in COMPRESSION_CONTEXT_GROUP.
   Updated both to the real, intentional order: Settings -> Combos ->
   engines -> Studio -> Exclusions (Studio now second-to-last,
   Exclusions last).

Validation (red -> green):
- check:error-helper gate: red ("1 entrada(s) obsoleta(s)") -> green
  ("OK (898 files scanned, 0 known-missing frozen)")
- tests/unit/check-error-helper.test.ts: 31/32 -> 32/32
- tests/unit/sidebar-visibility.test.ts: 6/7 -> 7/7
- tests/unit/ui/sidebar-engine-items.test.ts: 13/14 -> 14/14

Refs #8233
Refs #8064
HouMinXi pushed a commit to HouMinXi/OmniRoute that referenced this pull request Aug 2, 2026
@nguyenha935 @diegosouzapw
fix: normalize Codex URLs and dashboard regressions (cheaper-inferenc…
9f94706 
…e#8233)

Co-authored-by: nguyenha935 <208228297+nguyenha935@users.noreply.github.com>
Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
HouMinXi pushed a commit to HouMinXi/OmniRoute that referenced this pull request Aug 2, 2026
@diegosouzapw
chore(quality): drop stale muse-spark-web allowlist entry + sync side…
4c20270 
…bar order snapshots (cheaper-inference#8383)

Two independent "code is right, bookkeeping lagged" base-reds:

1. cheaper-inference#8233 made open-sse/executors/muse-spark-web.ts import
   sanitizeErrorMessage from utils/error.ts (a real Rule cheaper-inference#12 fix), but
   left its KNOWN_MISSING_ERROR_HELPER allowlist entry in
   scripts/check/check-error-helper.mjs in place. The gate's own
   stale-allowlist enforcement (assertNoStale) correctly flagged the now
   -obsolete entry: `npm run check:error-helper` failed with "1 entrada(s)
   obsoleta(s)", and tests/unit/check-error-helper.test.ts's "the shipped
   allowlist freezes exactly the known current violators" test expected
   an empty Set. Removed the entry (kept the assertNoStale machinery and
   the general scope-header comments untouched).

2. cheaper-inference#8064 added the "compression-exclusions" sidebar item right after
   "compression-studio" in COMPRESSION_CONTEXT_GROUP (deliberate,
   complete feature) but didn't update two order-snapshot tests written
   before that item existed:
   - tests/unit/sidebar-visibility.test.ts expected the "omni-proxy"
     section's flattened id list to end the compression block at
     "compression-studio".
   - tests/unit/ui/sidebar-engine-items.test.ts asserted "Studio must be
     last" in COMPRESSION_CONTEXT_GROUP.
   Updated both to the real, intentional order: Settings -> Combos ->
   engines -> Studio -> Exclusions (Studio now second-to-last,
   Exclusions last).

Validation (red -> green):
- check:error-helper gate: red ("1 entrada(s) obsoleta(s)") -> green
  ("OK (898 files scanned, 0 known-missing frozen)")
- tests/unit/check-error-helper.test.ts: 31/32 -> 32/32
- tests/unit/sidebar-visibility.test.ts: 6/7 -> 7/7
- tests/unit/ui/sidebar-engine-items.test.ts: 13/14 -> 14/14

Refs cheaper-inference#8233
Refs cheaper-inference#8064
muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
@nguyenha935 @diegosouzapw
fix: normalize Codex URLs and dashboard regressions (cheaper-inferenc…
5a2cce6 
…e#8233)

Co-authored-by: nguyenha935 <208228297+nguyenha935@users.noreply.github.com>
Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
@diegosouzapw
chore(quality): drop stale muse-spark-web allowlist entry + sync side…
66c9078 
…bar order snapshots (cheaper-inference#8383)

Two independent "code is right, bookkeeping lagged" base-reds:

1. cheaper-inference#8233 made open-sse/executors/muse-spark-web.ts import
   sanitizeErrorMessage from utils/error.ts (a real Rule cheaper-inference#12 fix), but
   left its KNOWN_MISSING_ERROR_HELPER allowlist entry in
   scripts/check/check-error-helper.mjs in place. The gate's own
   stale-allowlist enforcement (assertNoStale) correctly flagged the now
   -obsolete entry: `npm run check:error-helper` failed with "1 entrada(s)
   obsoleta(s)", and tests/unit/check-error-helper.test.ts's "the shipped
   allowlist freezes exactly the known current violators" test expected
   an empty Set. Removed the entry (kept the assertNoStale machinery and
   the general scope-header comments untouched).

2. cheaper-inference#8064 added the "compression-exclusions" sidebar item right after
   "compression-studio" in COMPRESSION_CONTEXT_GROUP (deliberate,
   complete feature) but didn't update two order-snapshot tests written
   before that item existed:
   - tests/unit/sidebar-visibility.test.ts expected the "omni-proxy"
     section's flattened id list to end the compression block at
     "compression-studio".
   - tests/unit/ui/sidebar-engine-items.test.ts asserted "Studio must be
     last" in COMPRESSION_CONTEXT_GROUP.
   Updated both to the real, intentional order: Settings -> Combos ->
   engines -> Studio -> Exclusions (Studio now second-to-last,
   Exclusions last).

Validation (red -> green):
- check:error-helper gate: red ("1 entrada(s) obsoleta(s)") -> green
  ("OK (898 files scanned, 0 known-missing frozen)")
- tests/unit/check-error-helper.test.ts: 31/32 -> 32/32
- tests/unit/sidebar-visibility.test.ts: 6/7 -> 7/7
- tests/unit/ui/sidebar-engine-items.test.ts: 13/14 -> 14/14

Refs cheaper-inference#8233
Refs cheaper-inference#8064
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diegosouzapw diegosouzapw Awaiting requested review from diegosouzapw diegosouzapw is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nguyenha935 @diegosouzapw