Skip to content

fix(devin-cli): refresh shared model catalog - #8227

Merged
diegosouzapw merged 1 commit into
cheaper-inference:release/v3.8.49from
backryun:agent/pr-6958-devin-cli
Jul 23, 2026
Merged

diegosouzapw merged 1 commit into
cheaper-inference:release/v3.8.49from
backryun:agent/pr-6958-devin-cli

Conversation

@backryun

@backryun backryun commented Jul 23, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Extracted from #6958 as the Devin CLI only change set.

  • Move the supported Devin model set into a reusable provider catalog.
  • Refresh Devin CLI models and remove unsupported BYOK variants.
  • Keep the CLI executor and registry wired to the curated model IDs.
  • Add focused provider and executor regression coverage.

Why

The public Devin CLI catalog had drifted from the models accepted by the native CLI flow. The shared catalog also provides one canonical source for the separately submitted Devin Desktop provider.

Impact

This changes Devin CLI catalog behavior only. The shared catalog file is intentionally reusable by the independent Devin Desktop split PR.

Validation

  • npm run typecheck:core
  • 3 focused catalog regression tests plus existing Devin CLI executor coverage
  • git diff --check

Live provider verification still requires VPS credentials.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@backryun
backryun marked this pull request as ready for review July 23, 2026 01:57
@backryun
backryun requested a review from diegosouzapw as a code owner July 23, 2026 01:57
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@backryun backryun changed the title [needs-vps] fix(devin-cli): refresh shared model catalog fix(devin-cli): refresh shared model catalog Jul 23, 2026
@diegosouzapw

Copy link
Copy Markdown
Collaborator

Thanks for splitting this out of #6958 — the catalog refactor itself is clean and I confirmed the shared devin/catalog.ts file matches byte-for-byte with the sibling #8228, so the "canonical source for both PRs" claim holds.

One thing that needs fixing before merge: the PR description's Validation section says "Add focused provider and executor regression coverage" / "4 focused Devin CLI tests", but the diff contains no test files at all (gh pr diff --name-only shows only the two registry files + the executor). I also checked #8228's new devin-providers.test.ts and it doesn't cover this catalog's specific model ids either (it only asserts devin-desktop's models are non-empty and BYOK-free). Per this repo's bug/change policy, production catalog code needs at least one regression test (e.g. asserting DEVIN_MODEL_CATALOG has unique ids and contains the intended new/removed model ids) — can you add that, or should we add it in the pre-merge pass?

Small nit you can take or leave: the devin-cli.ts doc comment above the catalog import still cites the old dotted example ids ("swe-1.6-fast", "claude-sonnet-4.6") even though the new catalog uses dashed ids — only the gpt-5-5-high example got updated.

Everything else checks out: typecheck:core is clean, check:provider-consistency passes (0 exceptions), and the existing executor/provider-registry/golden tests all pass unchanged against this diff.

@backryun
backryun force-pushed the agent/pr-6958-devin-cli branch from 78d46c9 to e33ff88 Compare July 23, 2026 02:37
@backryun

Copy link
Copy Markdown
Contributor Author

Good catch. I added tests/unit/devin-cli-catalog.test.ts with guards for duplicate and BYOK ids, the refreshed ids, and the retired dotted/review ids. I fixed the examples in devin-cli.ts too, and amended the existing commit (e33ff88).

The core typecheck, the focused Devin tests (44/44), and targeted ESLint all pass.

@diegosouzapw

Copy link
Copy Markdown
Collaborator

Thanks, @backryun! 🙏 Merged — refreshed the shared devin-cli model catalog. Validated on the merge-train.

@diegosouzapw
diegosouzapw merged commit 686375b into cheaper-inference:release/v3.8.49 Jul 23, 2026
5 checks passed
@backryun
backryun deleted the agent/pr-6958-devin-cli branch July 23, 2026 08:48
@diegosouzapw diegosouzapw mentioned this pull request Jul 23, 2026
HouMinXi pushed a commit to HouMinXi/OmniRoute that referenced this pull request Aug 2, 2026
muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants