Repository navigation
fix(devin-cli): refresh shared model catalog - #8227
diegosouzapw merged 1 commit into
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
Thanks for splitting this out of #6958 — the catalog refactor itself is clean and I confirmed the shared devin/catalog.ts file matches byte-for-byte with the sibling #8228, so the "canonical source for both PRs" claim holds. One thing that needs fixing before merge: the PR description's Validation section says "Add focused provider and executor regression coverage" / "4 focused Devin CLI tests", but the diff contains no test files at all ( Small nit you can take or leave: the devin-cli.ts doc comment above the catalog import still cites the old dotted example ids ("swe-1.6-fast", "claude-sonnet-4.6") even though the new catalog uses dashed ids — only the gpt-5-5-high example got updated. Everything else checks out: typecheck:core is clean, check:provider-consistency passes (0 exceptions), and the existing executor/provider-registry/golden tests all pass unchanged against this diff. |
78d46c9 to
e33ff88
Compare
|
Good catch. I added tests/unit/devin-cli-catalog.test.ts with guards for duplicate and BYOK ids, the refreshed ids, and the retired dotted/review ids. I fixed the examples in devin-cli.ts too, and amended the existing commit (e33ff88). The core typecheck, the focused Devin tests (44/44), and targeted ESLint all pass. |
|
Thanks, @backryun! 🙏 Merged — refreshed the shared devin-cli model catalog. Validated on the merge-train. |
686375b
into
cheaper-inference:release/v3.8.49
Summary
Extracted from #6958 as the Devin CLI only change set.
Why
The public Devin CLI catalog had drifted from the models accepted by the native CLI flow. The shared catalog also provides one canonical source for the separately submitted Devin Desktop provider.
Impact
This changes Devin CLI catalog behavior only. The shared catalog file is intentionally reusable by the independent Devin Desktop split PR.
Validation
Live provider verification still requires VPS credentials.