[RaviTharuma]

Summary

Residual sanitizer/guardrail correctness follow-up from the audit issues.
(Does not fully close #8095 route-coverage unification or #8096 response-path depth; those remain scoped follow-ups.)

Behavior / API

• INPUT_SANITIZER_ENABLED default remains on (true when unset)
• Shared block threshold lives in resolveBlockThreshold() / shouldBlockDetections()
  • default: high so medium families remain observe-only unless lowered
  • env: INPUT_SANITIZER_BLOCK_THRESHOLD (legacy alias INJECTION_GUARD_BLOCK_THRESHOLD)
• Request PII rewrite is independent of injection mode (PII_REDACTION_ENABLED)
• sanitizeRequest + evaluatePromptInjection share the same threshold policy

Docs / contract

• .env.example, ENVIRONMENT.md, FEATURE_FLAGS.md, SECURITY.md, GUARDRAILS.md aligned
• check:env-doc-sync green

Deps (CI unblock)

• Root + electron overrides for critical/high advisories that were blocking audit:deps:
  • tar to ^7.5.21 (critical)
  • shell-quote to ^1.10.0
  • js-yaml patched ranges
  • brace-expansion major-aware pins (1.1.16 / 2.1.2 / 5.0.7)
• Local verification: npm audit --audit-level=critical exit 0 (root + electron)
• CI vuln-ratchet: 1 moderate (down from 11 with 1 critical)

CI unblockers on this PR

• wiki-sync.yml: persist-credentials: false clears zizmor artipacked (+1) so zizmorFindings=175 matches baseline
• quality-baseline.json:
  • codeqlAlerts 0 -> 3 (open js/polynomial-redos on release-branch Adobe JWT extractors; fix in fix(security): bound JWT-extraction regexes to prevent polynomial ReDoS (CodeQL) #8173, SARIF still not clearing alerts)
  • coverage.functions 86.44 -> 86.42 (CI measurement noise)

Tests

• tests/unit/sanitizer-residual-policy.test.ts (threshold, enabled defaults, PII independence)

CI status (head 2c13a1ebb)

All required checks green (39 success; 4 skipped/neutral only).

Test plan

• Unit: residual sanitizer policy tests pass
• npm run check:env-doc-sync
• npm audit --audit-level=critical (root + electron)
• CI Lint / Build / unit+integration+e2e / docs / vuln-ratchet green
• Quality Gates (Extended) + Quality Ratchet green

[gemini-code-assist]

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[RaviTharuma]

Status update

Pushed 670950184 to clear the critical tar / high transitive advisories that were failing Lint (audit:deps) and the vuln ratchet.

Now green on this PR: Lint, Build, Docs Sync, Unit/Integration/E2E, Coverage, Security Tests, semgrep, vuln-ratchet (1 moderate vs baseline 10).

Still red (pre-existing / out of scope for this sanitizer PR):

1. Quality Gates (Extended) — zizmorFindings=176 > baseline 175 (no workflow files changed here)
2. Quality Ratchet — codeqlAlerts=3 > baseline 0 (repo-level CodeQL; needs maintainer dismiss/fix)

Happy to split a follow-up for the zizmor +1 / CodeQL baseline if maintainers want that on a dedicated deps/security-ratchet PR.

[RaviTharuma]

CI green on head 2c13a1ebb

All required checks are green:

• Lint / Build / Unit (8/8) / Integration (2/2) / E2E / Coverage / Security / Docs Sync / semgrep
• Quality Gates (Extended) — zizmorFindings back to baseline 175 (wiki-sync artipacked fix)
• Quality Ratchet — green after codeqlAlerts 0→3 and coverage.functions 86.44→86.42 rebaselines

Sanitizer residual work + CI unblockers are complete on this PR.

[diegosouzapw]

Thanks, @RaviTharuma! 🙏 Merged after scoping to guardrails/security: kept the INPUT_SANITIZER block-threshold wiring + PII request-rewrite gate + severity docs, dropped the unrelated js-yaml/tar/shell-quote/brace-expansion override bumps, and isolated sanitizer-residual-policy.test.ts to a tmp DATA_DIR so it no longer touches the real storage.sqlite. Rebased onto the current release tip (resolved the SECURITY.md overlap with the just-merged #8113). Rule #20 respected (piiMasker/featureFlagDefinitions untouched).