Repository navigation
Conversation
…heaper-inference#8074) resolveEmbeddingSource() was always returning dimensions=null for remote sources, even when the model is well-known in the registry (e.g. nvidia/nv-embedqa-e5-v5 → 1024, openai/text-embedding-3-small → 1536). This caused the EmbeddingResolution.dimensions field to be unusable for callers that need to pre-allocate vector stores or detect dimension conflicts without performing an actual embed call. Fix: - Import getEmbeddingDimension from embeddingRegistry. - Call getEmbeddingDimension(model) in both remote branches (explicit 'remote' source and auto-detected remote). - Use the resolved dimension in the dimensions field and in the signature string so the cache-key includes the actual dim. - Include dim=N in the reason string when dim is known (regression guard). - Unknown models gracefully fall back to null (no registry entry). Tests: all 25 in memory-resolve-dimensions-8074 + memory-embedding-resolve pass; full memory suite 86/86 green.
…-inference#8072) The /models catalog already exposes effort_tiers for thinking-capable models, but the Combo Builder path was missing it entirely. Add effortTiers to ComboBuilderModelOption, propagate through addModelOption (both create and merge paths), and populate via CANONICAL_EFFORT_VALUES in all four model loops (synced, builtin, custom, fallback) when supportsThinking is resolved true.
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Collaborator
|
Consolidating #8072 on #8165 (Dingding-leo), which surfaces the reasoning-effort variants from each model's |
Contributor
Author
|
Closing per maintainer feedback. Favoring #8165 (Dingding-leo) using supportedThinkingEfforts per issue's suggested approach. |
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8072
Problem
The
/modelscatalog path exposeseffort_tiersfor thinking-capable models, but the Combo Builder path (buildModelOptionsinbuilderOptions.ts) never surfaced this field. Clients using the combo step UI had no way to show effort selectors.Fix
effortTiers?: string[]toComboBuilderModelOptioninterfaceeffortTierstoaddModelOptioninput type with both create and merge pathseffortTiersfromCANONICAL_EFFORT_VALUESin all four model loops (synced, builtin, custom, fallback) whenresolved.supportsThinkingis trueThis mirrors exactly what the catalog path (
modelMetadataRegistry.ts) already does witheffort_tiers.Testing
tests/unit/combo-builder-effort-tiers-8072.test.ts— verifiesCANONICAL_EFFORT_VALUESis a valid non-empty array with expected values