Skip to content

chore(deps): bump js-yaml, brace-expansion, shell-quote, tar (security) - #7915

Merged
diegosouzapw merged 1 commit into
release/v3.8.49from
chore/deps-security-lockfile-bump
Jul 21, 2026
Merged

diegosouzapw merged 1 commit into
release/v3.8.49from
chore/deps-security-lockfile-bump

Conversation

@diegosouzapw

Copy link
Copy Markdown
Collaborator

Zera os 11 alertas abertos do Dependabot (https://github.com/diegosouzapw/OmniRoute/security/dependabot) — mudança lockfile-only + 1 override cirúrgico; nenhum código de runtime alterado.

Alertas resolvidos

Pacote Sev Advisory De → Para Manifests Alertas
js-yaml high CVE-2026-59869 / GHSA-52cp-r559-cp3m 4.2.0 → 4.3.0 raiz + electron #110, #114
brace-expansion high CVE-2026-13149 / GHSA-3jxr-9vmj-r5cp 1.1.13/1.1.15 → 1.1.16 · 2.1.1 → 2.1.2 · 5.0.6 → 5.0.7 raiz + electron #107–#109, #111–#113
shell-quote high CVE-2026-13311 / GHSA-395f-4hp3-45gv 1.8.4 → 1.10.0 raiz #119
tar medium CVE-2026-59871 / GHSA-w8wr-v893-vjvp 7.5.16 → 7.5.20 raiz + electron #118, #123

Todos são DoS/crash (ReDoS / complexidade quadrática-exponencial / PAX crash); o único em escopo runtime é o js-yaml do electron/package-lock.json (dep do electron-updater).

Por que o override de shell-quote

concurrently (já na última versão, 10.0.3) pina shell-quote exato em 1.8.4 — nenhum bump do pai resolve. O override por-pai (overrides.concurrently.shell-quote: "^1.9.0") segue o padrão já existente no repo (@yarnpkg/parsers.js-yaml, jsdom.undici, node-gyp.undici) e resolve para 1.10.0. concurrently é devDependency (scripts dev); não embarca em produção.

Validação

  • Diff auditado estruturalmente (comparação packages{} HEAD vs working nos dois locks): apenas os 4 pacotes acima mudaram de versão — nenhuma carona.
  • npm update --package-lock-only / npm install --package-lock-only (lock v3, mesmo fluxo do Dependabot); árvore resolvida sem vulnerabilidades (found 0 vulnerabilities).
  • Sem teste novo: não há mudança de código de produção (mesma política dos bumps semanais do Dependabot, ex. deps: bump the development group with 5 updates #7898); as suítes completas do CI validam a árvore resolvida.

Resolves all 11 open Dependabot alerts (lockfile-only; no runtime code change):

- js-yaml 4.2.0 -> 4.3.0 (CVE-2026-59869 / GHSA-52cp-r559-cp3m, high) - root + electron
- brace-expansion 1.1.x/2.1.1/5.0.6 -> 1.1.16/2.1.2/5.0.7 (CVE-2026-13149 /
  GHSA-3jxr-9vmj-r5cp, high) - root + electron
- shell-quote 1.8.4 -> 1.10.0 (CVE-2026-13311 / GHSA-395f-4hp3-45gv, high) - root.
  concurrently (latest 10.0.3) pins shell-quote exactly at 1.8.4, so this adds a
  per-parent override, same pattern as @yarnpkg/parsers.js-yaml
- tar 7.5.16 -> 7.5.20 (CVE-2026-59871 / GHSA-w8wr-v893-vjvp, medium) - root + electron
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@diegosouzapw

Copy link
Copy Markdown
Collaborator Author

Revisado — PR limpo e bem auditado. Confirmei de forma independente (diff estrutural direto dos dois package-lock.json, comparando packages{} HEAD vs PR) que exatamente os 4 pacotes citados mudaram de versão, sem nenhuma carona: brace-expansion (várias cópias aninhadas), js-yaml, shell-quote, tar. Nada mais no grafo de dependências foi tocado.

O override overrides.concurrently.shell-quote: "^1.9.0" resolve corretamente para 1.10.0 na árvore final (verifiquei a entrada top-level node_modules/shell-quote no lock resultante) — o padrão segue exatamente os overrides por-pai já existentes (@yarnpkg/parsers.js-yaml, jsdom.undici, node-gyp.undici).

Confirmei também o escopo runtime vs dev: js-yaml no electron/package-lock.json não tem dev:true (é dependência real do electron-updater, como o PR afirma); tar no mesmo lock tem dev:true. Bate exatamente com o que a descrição do PR alega.

19/19 checks de CI verdes (CodeQL, semgrep ×2, dast-smoke, Fast Quality Gates, Unit Tests 4/4 shards, Vitest, docs gates, merge-integrity). Sem alteração de código de produção — dispensa teste novo pela mesma política já usada em #7898.

Merge-ready.

@diegosouzapw

Copy link
Copy Markdown
Collaborator Author

Validated in local merge-train on tomni-proxmox-113 @ 6ca99b4c0268634827d021be29b5dde75d30c7bc (FAST gates green: static + changed tests + vitest)

@diegosouzapw
diegosouzapw merged commit 7c39a0e into release/v3.8.49 Jul 21, 2026
20 checks passed
@diegosouzapw
diegosouzapw deleted the chore/deps-security-lockfile-bump branch July 23, 2026 13:05
HouMinXi pushed a commit to HouMinXi/OmniRoute that referenced this pull request Aug 2, 2026
…y) (cheaper-inference#7915)

Resolves all 11 open Dependabot alerts (lockfile-only; no runtime code change):

- js-yaml 4.2.0 -> 4.3.0 (CVE-2026-59869 / GHSA-52cp-r559-cp3m, high) - root + electron
- brace-expansion 1.1.x/2.1.1/5.0.6 -> 1.1.16/2.1.2/5.0.7 (CVE-2026-13149 /
  GHSA-3jxr-9vmj-r5cp, high) - root + electron
- shell-quote 1.8.4 -> 1.10.0 (CVE-2026-13311 / GHSA-395f-4hp3-45gv, high) - root.
  concurrently (latest 10.0.3) pins shell-quote exactly at 1.8.4, so this adds a
  per-parent override, same pattern as @yarnpkg/parsers.js-yaml
- tar 7.5.16 -> 7.5.20 (CVE-2026-59871 / GHSA-w8wr-v893-vjvp, medium) - root + electron
muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
…y) (cheaper-inference#7915)

Resolves all 11 open Dependabot alerts (lockfile-only; no runtime code change):

- js-yaml 4.2.0 -> 4.3.0 (CVE-2026-59869 / GHSA-52cp-r559-cp3m, high) - root + electron
- brace-expansion 1.1.x/2.1.1/5.0.6 -> 1.1.16/2.1.2/5.0.7 (CVE-2026-13149 /
  GHSA-3jxr-9vmj-r5cp, high) - root + electron
- shell-quote 1.8.4 -> 1.10.0 (CVE-2026-13311 / GHSA-395f-4hp3-45gv, high) - root.
  concurrently (latest 10.0.3) pins shell-quote exactly at 1.8.4, so this adds a
  per-parent override, same pattern as @yarnpkg/parsers.js-yaml
- tar 7.5.16 -> 7.5.20 (CVE-2026-59871 / GHSA-w8wr-v893-vjvp, medium) - root + electron
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant