Skip to content

test(security): exact SAN-entry match in mitm leaf-cert test (CodeQL #746) #7824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegosouzapw merged 1 commit into from
Jul 20, 2026
Merged

test(security): exact SAN-entry match in mitm leaf-cert test (CodeQL #746) #7824

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions tests/unit/mitm-root-ca-leaf-issuance-6684.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,13 @@ test("issueLeafCert: issued leaf SAN matches the requested hostname", async () =
const leaf = await issueLeafCert(host, ca);
const leafPem = leaf.cert.split(/(?=-----BEGIN CERTIFICATE-----)/)[0];
const cert = new X509Certificate(leafPem);
// Exact SAN-entry membership, not a host substring: `includes(host)` would also
// pass for a SAN of "notexample.com" when host is "example.com", and CodeQL flags
// it as js/incomplete-url-substring-sanitization (#746).
const sanEntries = (cert.subjectAltName ?? "").split(",").map((entry) => entry.trim());
assert.ok(
cert.subjectAltName && cert.subjectAltName.includes(host),
`expected SAN to include ${host}, got ${cert.subjectAltName}`
sanEntries.includes(`DNS:${host}`),
`expected SAN to include DNS:${host}, got ${cert.subjectAltName}`
);
}
});
Expand Down
Loading