[backryun]

Summary

• replace the nonexistent Stepfun color icon import with the package's available monochrome export
• add the missing title frontmatter to the reasoning-routing documentation
• name the child-process mock default export to remove the ESLint warning
• move the AgentRouter dashboard test under the dashboard test loader so ESM-only icon dependencies load correctly
• align the Antigravity non-stream test with the executor's buffered JSON response contract

Root causes fixed

• dashboard code was being executed by the generic tsx/esm test loader, which cannot consume the ESM-only Lobe icon style module in that path
• the Antigravity test still attempted to parse SSE even though stream: false is intentionally buffered into JSON by the executor

Validation

• impacted Antigravity tests: 4/4 passed
• impacted dashboard tests: 62/62 passed
• test discovery check passed (3,490 tests, 25 collectors, 59 frozen orphans)
• ESLint JSON gate passed with 0 errors and 0 warnings
• commit hooks passed (Prettier, ESLint, documentation sync, any-budget, tracked artifacts)

[gemini-code-assist]

Code Review

This pull request adds frontmatter metadata to the reasoning routing documentation and updates the Stepfun provider icon configuration to use the monochrome icon for both mono and color states, removing the unused color icon import. The reviewer notes that according to the Repository Style Guide, tests should be included when modifying production code in src/, and requests adding or updating the corresponding test suite.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

The Repository Style Guide (Hard Rules, Rule 9) states: 'Always include tests when changing production code (src/, open-sse/, electron/, bin/)'. Since src/shared/components/lobeProviderIcons.ts has been modified, please add or update the corresponding test suite (e.g., under tests/) to cover this change and prevent future regressions with missing icon imports.

References

1. Always include tests when changing production code (src/, open-sse/, electron/, bin/).

[backryun]

@diegosouzapw Please review this priority, I fix the Review Error Entirely.

[diegosouzapw]

Thanks for the quick turnaround on this -- reviewed and reproduced the root cause independently.

Confirmed real: package-lock.json locks @lobehub/icons@5.13.0, and in that exact version the Stepfun icon set no longer ships a Color component (only Mono/Avatar/Combine/Text/Inner remain) -- I verified this directly by pulling the 5.13.0 tarball and inspecting its contents. Our devbox node_modules happens to be stale at 5.10.0 (where Color still exists), which is why this only shows up on a clean npm ci. I reproduced the exact crash locally by removing Color.js to simulate 5.13.0, and confirmed your fix resolves it. The REASONING_ROUTING.md frontmatter gap is also real -- it's the only file under docs/routing/ (registered in source.config.ts's fumadocs defineDocs()) missing a title.

One ask before merge: the two production-code changes (lobeProviderIcons.ts, tests/_cp_mock_module.mts) don't have a dedicated new test -- they're currently only covered incidentally, through an unrelated dashboard test that happens to transitively import the icon barrel. Could you add a small direct test (e.g. import lobeProviderIcons.ts and assert it doesn't throw / that Stepfun.color resolves) so this doesn't regress silently if that other test's import chain ever changes? Everything else here checks out clean (lint, migration numbering, tracked-artifacts, clean merge against the current release tip) -- ready to merge once that test lands.

[backryun]

@diegosouzapw really fixed, I hope merge this asap.

Thanks for the quick turnaround on this -- reviewed and reproduced the root cause independently.

Confirmed real: package-lock.json locks @lobehub/icons@5.13.0, and in that exact version the Stepfun icon set no longer ships a Color component (only Mono/Avatar/Combine/Text/Inner remain) -- I verified this directly by pulling the 5.13.0 tarball and inspecting its contents. Our devbox node_modules happens to be stale at 5.10.0 (where Color still exists), which is why this only shows up on a clean npm ci. I reproduced the exact crash locally by removing Color.js to simulate 5.13.0, and confirmed your fix resolves it. The REASONING_ROUTING.md frontmatter gap is also real -- it's the only file under docs/routing/ (registered in source.config.ts's fumadocs defineDocs()) missing a title.

One ask before merge: the two production-code changes (lobeProviderIcons.ts, tests/_cp_mock_module.mts) don't have a dedicated new test -- they're currently only covered incidentally, through an unrelated dashboard test that happens to transitively import the icon barrel. Could you add a small direct test (e.g. import lobeProviderIcons.ts and assert it doesn't throw / that Stepfun.color resolves) so this doesn't regress silently if that other test's import chain ever changes? Everything else here checks out clean (lint, migration numbering, tracked-artifacts, clean merge against the current release tip) -- ready to merge once that test lands.

I'll get right on it. Please wait about 5 minutes.

[backryun]

@diegosouzapw I've made the changes. Now you just need to merge them.

[diegosouzapw]

Thanks @backryun — this one landed at exactly the right moment. 🙌

Two of these fixes match problems I was independently chasing on the release tip today:

• tests/_cp_mock_module.mts — naming the default export clears the import/no-anonymous-default-export warning that check:release-green was reporting as the +1 ESLint warning drift on the tip. Nice catch.
• agentrouter-connection-modal-fields.test.ts → tests/unit/dashboard/ — this was failing for me on the 32-core validation box but passing on the devbox, and I had it parked as 'machine-specific'. Your diagnosis is the real one: it was the generic tsx/esm loader being unable to consume the ESM-only Lobe icon style module. Moving it under the dashboard loader is the correct fix.

For the record on the Antigravity piece: the executor-contract realignment already landed on the tip earlier today (227e382, same conclusion — the non-stream path returns a converted chat.completion, not raw SSE), so your change there reduces to the comment update. No conflict, and we independently reached the same contract.

Validated in local merge-train @ 10777cb08 (FAST gates green: static + changed tests + vitest).