Skip to content

Completing Arabic language - #7686

Merged
diegosouzapw merged 6 commits into
cheaper-inference:release/v3.8.49from
mustafa-phd:release/v3.8.49
Jul 19, 2026
Merged

diegosouzapw merged 6 commits into
cheaper-inference:release/v3.8.49from
mustafa-phd:release/v3.8.49

Conversation

@mustafa-phd

Copy link
Copy Markdown
Contributor

Completing Arabic language

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@mustafa-phd

Copy link
Copy Markdown
Contributor Author

Sorry, there were some errors due to the translation of Fable 5

@diegosouzapw

Copy link
Copy Markdown
Collaborator

Thank you for finishing off the Arabic locale — I verified the JSON diff directly: this PR replaces all 659 remaining MISSING:* placeholders and the leftover English strings with real Arabic translations (spot-checked several, they read correctly, no obvious encoding/RTL corruption), and it doesn't touch any runtime code (single-file, src/i18n/messages/ar.json only) — good.

However, comparing the full key set against release/v3.8.49, this PR drops the entire reasoningRouting.* namespace (69 keys: reasoningRouting.title, .model, .effort, .scope., .mode., etc.) — they exist in the current file but are missing from your version. That will break/blank the Reasoning Routing settings page for Arabic users. Could you restore those 69 keys (translated, ideally) before this merges? Everything else looks ready.

mustafa-phd and others added 3 commits July 19, 2026 12:13
Resolved the src/i18n/messages/ar.json conflict by keeping the release tip's
key structure (which gained providers.kimiOfficialSupporterBadge/Tooltip from
#7775) and applying the contributor's Arabic translations on top: 7538 keys in,
7538 keys out, 0 missing, 0 extra, 3826 translated values preserved.

Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
@diegosouzapw

Copy link
Copy Markdown
Collaborator

Thanks @mustafa-phd! Merging the Arabic locale completion. Your branch had drifted into a conflict on src/i18n/messages/ar.json (the tip gained providers.kimiOfficialSupporterBadge/Tooltip from #7775), so I resolved it by keeping the tip's key structure and applying your translations on top — verified 7538 keys in / 7538 out, 0 missing, 0 extra, 3826 translated values preserved. Validated in local merge-train @ 2ae9ba63c (FAST gates green: static + changed tests + vitest).

@diegosouzapw
diegosouzapw merged commit 0842bad into cheaper-inference:release/v3.8.49 Jul 19, 2026
3 checks passed
@diegosouzapw diegosouzapw mentioned this pull request Jul 23, 2026
HouMinXi pushed a commit to HouMinXi/OmniRoute that referenced this pull request Aug 2, 2026
* Add files via upload

* update ar.json

* update ar.json

* update ar.json

* update ar.json

---------

Co-authored-by: mustafa-phd <mustafa-phd@users.noreply.github.com>
Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
* Add files via upload

* update ar.json

* update ar.json

* update ar.json

* update ar.json

---------

Co-authored-by: mustafa-phd <mustafa-phd@users.noreply.github.com>
Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants