Repository navigation
fix(embeddings): add lmstudio to embedding provider registry - #7614
diegosouzapw merged 2 commits into
Conversation
LM Studio is already registered as a local provider in the provider catalog (src/shared/constants/providers/local.ts) but was missing from EMBEDDING_PROVIDERS in open-sse/config/embeddingRegistry.ts. This caused /v1/embeddings requests targeting lmstudio models to fail with 'Unknown embedding provider: lmstudio'. Follows the same pattern as deepinfra (#2298) and openrouter (#960), but with authType: 'none' since LM Studio is a local server. Fixes #7601
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Thanks for this — confirmed the fix is correct and matches the pattern from #2298/#960: Two small things needed before merge, following the same pattern as the mixedbread (#6660) and openrouter-embeddings (#6976) PRs that touched this same registry:
Also: this PR is opened against |
Adds the regression test and changelog fragment required by the contribution guidelines (Hard Rule #18) for the new lmstudio entry in EMBEDDING_PROVIDERS, mirroring the precedent set by the mixedbread (#6660) and openrouter-embeddings (#6976) provider-registry additions: - tests/unit/lmstudio-embedding-provider-7601.test.ts: asserts getEmbeddingProvider('lmstudio').baseUrl/authType/authHeader and parseEmbeddingModel('lmstudio/<model>') passthrough resolution (including namespaced model ids). Verified red without the registry entry (assert.ok(provider) fails), green with it. - changelog.d/features/7601-lmstudio-embeddings.md: changelog fragment referencing issue #7601 and the new test. Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
2ad7da5
into
cheaper-inference:release/v3.8.49
|
Merged into |
…-inference#7614) * fix(embeddings): add lmstudio to embedding provider registry LM Studio is already registered as a local provider in the provider catalog (src/shared/constants/providers/local.ts) but was missing from EMBEDDING_PROVIDERS in open-sse/config/embeddingRegistry.ts. This caused /v1/embeddings requests targeting lmstudio models to fail with 'Unknown embedding provider: lmstudio'. Follows the same pattern as deepinfra (cheaper-inference#2298) and openrouter (cheaper-inference#960), but with authType: 'none' since LM Studio is a local server. Fixes cheaper-inference#7601 * test(embeddings): add lmstudio regression test + changelog (cheaper-inference#7601) Adds the regression test and changelog fragment required by the contribution guidelines (Hard Rule cheaper-inference#18) for the new lmstudio entry in EMBEDDING_PROVIDERS, mirroring the precedent set by the mixedbread (cheaper-inference#6660) and openrouter-embeddings (cheaper-inference#6976) provider-registry additions: - tests/unit/lmstudio-embedding-provider-7601.test.ts: asserts getEmbeddingProvider('lmstudio').baseUrl/authType/authHeader and parseEmbeddingModel('lmstudio/<model>') passthrough resolution (including namespaced model ids). Verified red without the registry entry (assert.ok(provider) fails), green with it. - changelog.d/features/7601-lmstudio-embeddings.md: changelog fragment referencing issue cheaper-inference#7601 and the new test. Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com> --------- Co-authored-by: Erick Kinnee <erickinnee@gmail.com> Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
…-inference#7614) * fix(embeddings): add lmstudio to embedding provider registry LM Studio is already registered as a local provider in the provider catalog (src/shared/constants/providers/local.ts) but was missing from EMBEDDING_PROVIDERS in open-sse/config/embeddingRegistry.ts. This caused /v1/embeddings requests targeting lmstudio models to fail with 'Unknown embedding provider: lmstudio'. Follows the same pattern as deepinfra (cheaper-inference#2298) and openrouter (cheaper-inference#960), but with authType: 'none' since LM Studio is a local server. Fixes cheaper-inference#7601 * test(embeddings): add lmstudio regression test + changelog (cheaper-inference#7601) Adds the regression test and changelog fragment required by the contribution guidelines (Hard Rule cheaper-inference#18) for the new lmstudio entry in EMBEDDING_PROVIDERS, mirroring the precedent set by the mixedbread (cheaper-inference#6660) and openrouter-embeddings (cheaper-inference#6976) provider-registry additions: - tests/unit/lmstudio-embedding-provider-7601.test.ts: asserts getEmbeddingProvider('lmstudio').baseUrl/authType/authHeader and parseEmbeddingModel('lmstudio/<model>') passthrough resolution (including namespaced model ids). Verified red without the registry entry (assert.ok(provider) fails), green with it. - changelog.d/features/7601-lmstudio-embeddings.md: changelog fragment referencing issue cheaper-inference#7601 and the new test. Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com> --------- Co-authored-by: Erick Kinnee <erickinnee@gmail.com> Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
Problem
LM Studio is already registered as a local provider in the provider catalog (
src/shared/constants/providers/local.ts) but was missing fromEMBEDDING_PROVIDERSinopen-sse/config/embeddingRegistry.ts. This caused/v1/embeddingsrequests targeting lmstudio models to fail with:Solution
Added
lmstudiotoEMBEDDING_PROVIDERSwithauthType: "none"andauthHeader: "none"since LM Studio is a local server. Models array is empty — LM Studio exposes its own model list (passthrough).Follows the same pattern as deepinfra (#2298) and openrouter (#960), but with no auth since it's local.
Evidence
src/shared/constants/providers/local.ts(id:lm-studio, alias:lmstudio)EMBEDDING_PROVIDERSregistry was the only gapFixes #7601