Repository navigation
test(ci): static body in codex e2e mock route bridge (CodeQL #737) - #7558
Merged
Merged
Conversation
CodeQL js/stack-trace-exposure flags ANY error-derived value returned in the mock route bridge's 500 path, not just error.stack — swapping .stack for error.message (in #7354, alert #736) left sibling alert #737 open on the same line. Replace the body with a static string; the test only asserts status===200, so the 500 body is never inspected. Clears the last open CodeQL alert repo-wide, unblocking the Quality Ratchet on every PR.
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
HouMinXi
pushed a commit
to HouMinXi/OmniRoute
that referenced
this pull request
Aug 2, 2026
…inference#737) (cheaper-inference#7558) CodeQL js/stack-trace-exposure flags ANY error-derived value returned in the mock route bridge's 500 path, not just error.stack — swapping .stack for error.message (in cheaper-inference#7354, alert cheaper-inference#736) left sibling alert cheaper-inference#737 open on the same line. Replace the body with a static string; the test only asserts status===200, so the 500 body is never inspected. Clears the last open CodeQL alert repo-wide, unblocking the Quality Ratchet on every PR.
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…inference#737) (cheaper-inference#7558) CodeQL js/stack-trace-exposure flags ANY error-derived value returned in the mock route bridge's 500 path, not just error.stack — swapping .stack for error.message (in cheaper-inference#7354, alert cheaper-inference#736) left sibling alert cheaper-inference#737 open on the same line. Replace the body with a static string; the test only asserts status===200, so the 500 body is never inspected. Clears the last open CodeQL alert repo-wide, unblocking the Quality Ratchet on every PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces the error-derived 500 body in the codex Responses e2e mock route bridge (
tests/integration/codex-chat-reasoning-http-e2e.test.ts, line 184) with a static string.Why
CodeQL
js/stack-trace-exposureflags any error-derived value returned from that catch, not onlyerror.stack:error.stack→error.messageand cleared alert chore(release): v3.2.5 — Void Linux support #736 ✅error.message/String(error)as stack-exposure too.#737 is currently the only open CodeQL alert in the whole repo, and
check:codeql-ratchetcounts alerts repo-wide → it keepsQuality Ratchetred on every open PR. This closes it at the source.Fix
The test only asserts
status === 200, so the 500 body is never inspected — no assertion weakened.Validation (Hard Rule #18)
node --import tsx/esm --test tests/integration/codex-chat-reasoning-http-e2e.test.ts→ 1 pass, 0 fail.Companion PR opens against
main(the file exists on both branches) per merge-gates §8.