Skip to content

fix(ci): fetch full base history in pr-test-policy (shallow graft breaks merge-base) #7501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegosouzapw merged 1 commit into from
Jul 17, 2026
Merged

fix(ci): fetch full base history in pr-test-policy (shallow graft breaks merge-base) #7501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,7 @@ jobs:
with:
node-version: ${{ env.CI_NODE_VERSION }}
- name: Fetch base branch
run: git fetch --no-tags origin "${GITHUB_BASE_REF}" --depth=1
run: git fetch --no-tags origin "${GITHUB_BASE_REF}"
- name: Validate source changes include tests
run: node scripts/check/check-pr-test-policy.mjs --summary-file .artifacts/pr-test-policy.md
# Anti test-masking: flag net assert removal / new assert.ok(true) in changed tests.
Expand Down
1 change: 1 addition & 0 deletions changelog.d/maintenance/ci-pr-test-policy-shallow-base.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- CI: `pr-test-policy` fetches the base branch with full history instead of `--depth=1` — the shallow graft made `merge-base` resolve wrong for PR branches that recently merged the release, so the three-dot diff blamed the PR for OTHER merged PRs' changes (false "deleted test"/"weakened asserts" reds; observed on #7329 being blamed for #7106's files).

@gemini-code-assist gemini-code-assist Bot Jul 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This changelog entry is quite verbose and includes a lot of implementation detail. For better readability in the final changelog, it's often best to keep entries concise, focusing on the 'what' and 'why' at a high level. The specific PR numbers and error types are excellent for a commit message but can clutter the changelog.

A more scannable version could be:

- CI: The `pr-test-policy` job now fetches full git history for the base branch. This fixes incorrect merge-base detection on shallow clones, preventing spurious CI failures that wrongly attributed changes from other PRs.
Suggested change
- CI: `pr-test-policy` fetches the base branch with full history instead of `--depth=1` — the shallow graft made `merge-base` resolve wrong for PR branches that recently merged the release, so the three-dot diff blamed the PR for OTHER merged PRs' changes (false "deleted test"/"weakened asserts" reds; observed on #7329 being blamed for #7106's files).
- CI: The `pr-test-policy` job now fetches full git history for the base branch. This fixes incorrect merge-base detection on shallow clones, preventing spurious CI failures that wrongly attributed changes from other PRs.

Loading